Skip to content

Conversation

@shahthepro
Copy link
Collaborator

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@rafaelugolini rafaelugolini temporarily deployed to preview-oeth-shah-july--cdm3am July 17, 2023 06:27 Inactive
@shahthepro shahthepro temporarily deployed to preview-oeth-shah-july--cdm3am July 17, 2023 06:38 Inactive
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1702 (e4fe304) into master (6ab3906) will not change coverage.
The diff coverage is n/a.

❗ Current head e4fe304 differs from pull request most recent head 1d78eda. Consider uploading reports for the commit 1d78eda to get more accurate results

@@           Coverage Diff           @@
##           master    #1702   +/-   ##
=======================================
  Coverage   69.34%   69.34%           
=======================================
  Files          44       44           
  Lines        2349     2349           
  Branches      617      617           
=======================================
  Hits         1629     1629           
  Misses        717      717           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@naddison36 naddison36 added the contracts Works related to contracts label Jul 25, 2023
@shahthepro shahthepro marked this pull request as ready for review July 25, 2023 13:46
@shahthepro shahthepro merged commit 15277fc into master Jul 25, 2023
@shahthepro shahthepro deleted the shah/july-17-runlog branch July 25, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contracts Works related to contracts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants