Skip to content

[Base] Deploy Pool Booster setup - #2636

Merged
clement-ux merged 1 commit into
masterfrom
clement/pb-on-base
Sep 1, 2025
Merged

[Base] Deploy Pool Booster setup#2636
clement-ux merged 1 commit into
masterfrom
clement/pb-on-base

Conversation

@clement-ux

Copy link
Copy Markdown
Collaborator

Description

  • Deploying Central Registry Proxy and implementation.
  • Deploying PoolBooster Factory Merkl
  • Call approveFactory on CentralRegistry to approve PBFactory Merkl

Contract

Name Address
Central Registry Proxy 0x157f0B239D7F83D153E6c95F8AD9d341694376E3
Central Registry implem 0x9a0D74a4C18A80Fce757BFCC1257a983Ef84314C
PoolBoosterFactory Merkl 0x1ADB902Ece465cA681C66187627a622a631a0a63

Governance

  • Pick contracts/deployments/base/operations/039_pool_booster_factory.schedule.json and copy it on the 5/8 MS Base Governor to schedule the call.
  • After 2 days, pick contracts/deployments/base/operations/039_pool_booster_factory.execute.json and copy it on the 2/8 MS Base Operator to execute the call.

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@clement-ux clement-ux self-assigned this Aug 27, 2025
@clement-ux clement-ux added the deployment Deploying smart contract label Aug 27, 2025
@codecov

codecov Bot commented Aug 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.26%. Comparing base (a8be73b) to head (a94bfdc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2636   +/-   ##
=======================================
  Coverage   38.26%   38.26%           
=======================================
  Files         112      112           
  Lines        5331     5331           
  Branches     1412     1412           
=======================================
  Hits         2040     2040           
  Misses       3289     3289           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sparrowDom

sparrowDom commented Aug 27, 2025

Copy link
Copy Markdown
Member
  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
npx sol2uml diff 0x157f0B239D7F83D153E6c95F8AD9d341694376E3 .,node_modules --network base --apiKey xxxxx
Compared the "PoolBoostCentralRegistryProxy" contract with address 0x157f0B239D7F83D153E6c95F8AD9d341694376E3 on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match   contracts/proxies/Proxies.sol


npx sol2uml diff 0x9a0D74a4C18A80Fce757BFCC1257a983Ef84314C .,node_modules --network base --apiKey xxxxx
Compared the "PoolBoostCentralRegistry" contract with address 0x9a0D74a4C18A80Fce757BFCC1257a983Ef84314C on base
to local files under folders ".,node_modules"

match   contracts/governance/Governable.sol
match   contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match   contracts/poolBooster/PoolBoostCentralRegistry.sol

npx sol2uml diff 0x1ADB902Ece465cA681C66187627a622a631a0a63 .,node_modules --network base --apiKey xxxxx

Compared the "PoolBoosterFactoryMerkl" contract with address 0x1ADB902Ece465cA681C66187627a622a631a0a63 on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/poolBooster/IMerklDistributor.sol
match   contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match   contracts/interfaces/poolBooster/IPoolBooster.sol
match   contracts/poolBooster/AbstractPoolBoosterFactory.sol
match   contracts/poolBooster/PoolBoosterFactoryMerkl.sol
match   contracts/poolBooster/PoolBoosterMerkl.sol
  • Contract constructors have correct arguments
    • yes the registry has 5/8 governor and the Merkle Factory has 2/8
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
cast cdd "scheduleBatch(address[],uint256[],bytes[],bytes32,bytes32,uint256)" 0x8f2a0bb000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000000000000000000000000000000000000000000006ff1266360ed7835243f47fb3892b181103752cdfb237f87211b6b8c28be9e7000000000000000000000000000000000000000000000000000000000002a3000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000157f0b239d7f83d153e6c95f8ad9d341694376e300000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000024adda33c50000000000000000000000001adb902ece465ca681c66187627a622a631a0a6300000000000000000000000000000000000000000000000000000000
[0x157f0B239D7F83D153E6c95F8AD9d341694376E3] // proxy conttact
[0]
[0xadda33c50000000000000000000000001adb902ece465ca681c66187627a622a631a0a63] // approve factory
0x0000000000000000000000000000000000000000000000000000000000000000
0x06ff1266360ed7835243f47fb3892b181103752cdfb237f87211b6b8c28be9e7
172800 [1.728e5]
  • Smoke tests pass after fork test execution of the governance proposal

@clement-ux
clement-ux merged commit d5fd2cd into master Sep 1, 2025
16 of 19 checks passed
@clement-ux
clement-ux deleted the clement/pb-on-base branch September 1, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Deploying smart contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants