Deploy Sonic Vault Core

[sparrowDom]

Deploying:

• remove the calls to the Dripper from VaultCore

Contract

Name	Address
OSonicVaultCore	0xd66afaA7Fe071162d055B3CC703CC1eAED836CF3

Governance actions

Name	Address
Schedule	contracts/deployments/sonic/operations/025_vault_upgrade.schedule.json
Execute	contracts/deployments/sonic/operations/025_vault_upgrade.execute.json

Deploy checklist

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.26%. Comparing base (d5fd2cd) to head (183ee8f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2648   +/-   ##
=======================================
  Coverage   38.26%   38.26%           
=======================================
  Files         112      112           
  Lines        5331     5331           
  Branches     1412     1412           
=======================================
  Hits         2040     2040           
  Misses       3289     3289           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shahthepro]

Code diff with current implementation (license changes and changes to remove dripper from previous commits, so it's all good):

Compared the "OSonicVaultCore" contract with address 0x087a3E2b1342ddC7C4c8aF6d7D3E5C8eA78dCbd9 on sonic
to the "OSonicVaultCore" contract with address 0xd66afaA7Fe071162d055B3CC703CC1eAED836CF3 on sonic

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
changed contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
removed contracts/interfaces/IDripper.sol
match   contracts/interfaces/IGetExchangeRateToken.sol
changed contracts/interfaces/IOracle.sol
changed contracts/interfaces/IStrategy.sol
added   contracts/interfaces/IVault.sol
changed contracts/token/OUSD.sol
changed contracts/utils/Helpers.sol
changed contracts/utils/Initializable.sol
changed contracts/utils/StableMath.sol
changed contracts/vault/OETHVaultCore.sol
match   contracts/vault/OSonicVaultCore.sol
changed contracts/vault/VaultCore.sol
changed contracts/vault/VaultInitializer.sol
changed contracts/vault/VaultStorage.sol

[shahthepro]

🔴 Vault proxy address in the ops files are wrong

[clement-ux]

• All deployed contracts are listed in the deploy PR's description
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
• The transactions that interacted with the newly deployed contract match the deploy script.
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal

Diff contract

sol2uml diff 0x087a3E2b1342ddC7C4c8aF6d7D3E5C8eA78dCbd9 0xd66afaA7Fe071162d055B3CC703CC1eAED836CF3 -n sonic --apiKey XSK3578ESKKSXH85ZZZZ1FGZ4JBWZQT1CX

Compared the "OSonicVaultCore" contract with address 0x087a3E2b1342ddC7C4c8aF6d7D3E5C8eA78dCbd9 on sonic
to the "OSonicVaultCore" contract with address 0xd66afaA7Fe071162d055B3CC703CC1eAED836CF3 on sonic

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
changed contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
removed contracts/interfaces/IDripper.sol
match   contracts/interfaces/IGetExchangeRateToken.sol
changed contracts/interfaces/IOracle.sol
changed contracts/interfaces/IStrategy.sol
added   contracts/interfaces/IVault.sol
changed contracts/token/OUSD.sol
changed contracts/utils/Helpers.sol
changed contracts/utils/Initializable.sol
changed contracts/utils/StableMath.sol
changed contracts/vault/OETHVaultCore.sol
match   contracts/vault/OSonicVaultCore.sol
changed contracts/vault/VaultCore.sol
changed contracts/vault/VaultInitializer.sol
changed contracts/vault/VaultStorage.sol

[clement-ux]

LGTM 👍

[shahthepro]

• All deployed contracts are listed in the deploy PR's description
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
• The transactions that interacted with the newly deployed contract match the deploy script.
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal