Skip to content

Remove legacy Hardhat deployment scripts - #2983

Open
clement-ux wants to merge 3 commits into
chore/remove-hardhat-contract-testsfrom
chore/remove-hardhat-deploy-scripts
Open

Remove legacy Hardhat deployment scripts#2983
clement-ux wants to merge 3 commits into
chore/remove-hardhat-contract-testsfrom
chore/remove-hardhat-deploy-scripts

Conversation

@clement-ux

@clement-ux clement-ux commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Why

Deployments have moved to Foundry, but the repository still contained 129 old hardhat-deploy scripts and the helpers built around them. They were no longer the deployment system, yet generating @origin/defi could still load and execute that old pipeline.

This PR removes the executable Hardhat deployment path while keeping the operational tools that still need historical deployment information.

What changes

  • remove the 129 legacy scripts under contracts/deploy/**
  • remove deploy-only helpers and npm commands
  • stop ABI generation from running hardhat deploy
  • keep only the small network, unit, funding and governance helpers still used by operational tasks
  • point the deployment-verification skill at the Foundry deployment scripts

At this point in the stack, ABI generation uses a clean Hardhat compilation only; follow-up #2985 replaces that final compilation with Foundry.

What stays

deployments/** is intentionally kept. These files are not executable deployment scripts: they are the address and ABI records used by Talos and other operational tasks to find existing contracts.

hardhat-deploy also remains as a read-only adapter for those records. It is no longer used to deploy anything.

Stack

This PR is intentionally based on #2982, not master:

  1. Remove legacy Hardhat contract tests #2982 — remove legacy Hardhat contract tests
  2. Remove legacy Hardhat deployment scripts #2983 — remove legacy Hardhat deployment scripts
  3. Generate ABI package with Foundry #2985 — generate the ABI package with Foundry

Validation

  • @origin/defi generation succeeds without executing deployments: 292 ABI files
  • Hardhat governance tasks execute and executeOnFork load successfully
  • pnpm run test:tasks: 22 passing
  • pnpm run test:scripts: 61 passing
  • pnpm run test:layouts: 11 passing
  • forge build contracts/ --force -j 1
  • JavaScript/TypeScript lint, typecheck, Prettier and git diff --check pass

sparrowDom
sparrowDom previously approved these changes Aug 27, 2026

@sparrowDom sparrowDom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants