FIx hardhat timeouts#552
Merged
Merged
Conversation
tomlinton
approved these changes
Feb 10, 2021
franckc
approved these changes
Feb 10, 2021
franckc
left a comment
There was a problem hiding this comment.
Thanks for figuring this out! :) LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the timeout problem with hardhat fork network. The interesting thing is that if
localhostnetwork config is not passed tohardhat.config.jsdefault config values are created with 20s timeout -> see here. Increasing this to 60 seconds solves timeouts for me. If it is not enough it can be increased even further.It is good to keep in mind that these are the timeouts of http client providers that connect to the local running node. If node takes more than 20 seconds to respond, the client retries. And (I think) after 3 retries times out. There is another timeout that is relevant. If node happens to timeout when reaching its provider we would need to change this setting. Though this timeout should be spotted in the node's terminal.
Note: I think this PR ranks the lowest score in
time requred / code producedrating 😃Contract change checklist: