Skip to content

FIx hardhat timeouts#552

Merged
sparrowDom merged 2 commits into
masterfrom
sparrowDom/hardhatTimeout
Feb 10, 2021
Merged

FIx hardhat timeouts#552
sparrowDom merged 2 commits into
masterfrom
sparrowDom/hardhatTimeout

Conversation

@sparrowDom

Copy link
Copy Markdown
Member

Fixes the timeout problem with hardhat fork network. The interesting thing is that if localhost network config is not passed to hardhat.config.js default config values are created with 20s timeout -> see here. Increasing this to 60 seconds solves timeouts for me. If it is not enough it can be increased even further.

It is good to keep in mind that these are the timeouts of http client providers that connect to the local running node. If node takes more than 20 seconds to respond, the client retries. And (I think) after 3 retries times out. There is another timeout that is relevant. If node happens to timeout when reaching its provider we would need to change this setting. Though this timeout should be spotted in the node's terminal.

Note: I think this PR ranks the lowest score in time requred / code produced rating 😃

Contract change checklist:

  • Code reviewed by 2 reviewers. See template and example.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@franckc franckc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! :) LGTM

@sparrowDom sparrowDom merged commit 3dea5d0 into master Feb 10, 2021
@sparrowDom sparrowDom deleted the sparrowDom/hardhatTimeout branch February 10, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants