Skip to content

Governance proposal to add DAI to the Compound strategy#596

Merged
franckc merged 1 commit into
masterfrom
franck/proposal
Jun 9, 2021
Merged

Governance proposal to add DAI to the Compound strategy#596
franckc merged 1 commit into
masterfrom
franck/proposal

Conversation

@franckc
Copy link
Copy Markdown

@franckc franckc commented Jun 9, 2021

Script to generate the governance proposal for #496

=====

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers. See template and example.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@franckc
Copy link
Copy Markdown
Author

franckc commented Jun 9, 2021

Here is the dry-run output:

francks-mbp:governor franck$ node propose.js --compoundDAI
Current proposal count= 27
proposeCompoundDAI
Would send a tx to call propose() on 0x8e7bDFeCd1164C46ad51b58e49A611F954D23377
args: [
  [ '0xD5433168Ed0B1F7714819646606DB509D9d8EC1f' ],
  [ 'setPTokenAddress(address,address)' ],
  [
    '0x0000000000000000000000006b175474e89094c44da98b954eedeac495271d0f0000000000000000000000005d3a536e4d6dbd6114cc1ead35777bab948e3643'
  ]
]
New proposal count= 27
Next step: call the following method on the governor at 0x8e7bDFeCd1164C46ad51b58e49A611F954D23377 via multi-sig
   queue(27)
Done

@DanielVF
Copy link
Copy Markdown
Contributor

DanielVF commented Jun 9, 2021

Looks great. I appreciate how clear the code reads.

  • DAI address correct
  • CDAI address correct
  • Strategy address correct
  • Method call correct

@franckc franckc merged commit 628b491 into master Jun 9, 2021
@franckc franckc deleted the franck/proposal branch June 9, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants