Unique string generation system#119
Merged
maxbrundev merged 1 commit intodevelopfrom Sep 27, 2020
Merged
Conversation
adriengivry
added
QoL
Previously, the asset duplication naming system was adding `(Copy)` after the name of each duplicated asset. However, like in our previous actor duplication naming system, this nomenclature was very heavy and caused relatively long asset names after multiple duplications. In order to avoid code duplication, the actor duplication naming system has been generalized in OvTools::Utils::String as a function able to generate a unique string satisfying a predicate. This new function (Responsible of adding integer suffixes between parentheses) is based on the previous actor duplication naming system. It is now used by both the asset browser and the hierarchy to generate unique names for actors and assets.
adriengivry
force-pushed
the
feature/new_asset_duplication_naming_system
branch
from
7f8202d to
ad3cbfc
Compare
maxbrundev
approved these changes
Sep 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumary
This PR adds a unique string generation system, applied to asset and actor duplication.
Description
Previously, the asset duplication naming system was adding
(Copy)after the name of each duplicated asset. However, like in our previous actor duplication naming system, this nomenclature was very heavy and caused relatively long asset names after multiple duplications.In order to avoid code duplication, the actor duplication naming system has been generalized in
OvTools::Utils::Stringas a function able to generate a unique string satisfying a predicate.This new function (Responsible of adding integer suffixes between parentheses) is based on the previous actor duplication naming system.
It is now used by both the asset browser and the hierarchy to generate unique names for actors and assets.
Screenshots
Both of these windows (
AssetBrowserandHierarchy) are using the new string generation systemRelated to #99
Fixes #109