Added dynamic editor window size selection#328
Merged
adriengivry merged 1 commit intomainfrom Feb 15, 2025
Merged
Conversation
adriengivry
requested review from
BenjaminViranin,
litelawliet and
maxbrundev
adriengivry
added
QoL
litelawliet
reviewed
Feb 14, 2025
* default window size selected to fix the highest available resolution in a pre-determined 16:9 resolutions list. * if no available resolution is found (work area < 640, 360), an exception is thrown.
adriengivry
force-pushed
the
feature/dynamic_editor_window_size
branch
from
8b17b00 to
8ecb999
Compare
litelawliet
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Problem
When working with higher resolution monitor, the default window size for Overload can be very small (1600x900). Instead of hard-coding the default resolution, it should be selected from a list of preset.
Description
GetWorkAreaSizemethod to theDevice, allowing the editor to retrieve the "workable area" (aka safe size)Related Issues
N/A