Reworked the scripting system to be fully agnostic#355
Merged
adriengivry merged 18 commits intomainfrom Feb 16, 2025
Merged
Conversation
adriengivry
added
QoL
adriengivry
force-pushed
the
feature/agnostic_scripting_backend
branch
2 times, most recently
from
f04ad88 to
aacf055
Compare
adriengivry
changed the title
adriengivry
force-pushed
the
feature/agnostic_scripting_backend
branch
from
6b74459 to
2abd81f
Compare
litelawliet
reviewed
Feb 14, 2025
litelawliet
reviewed
Feb 14, 2025
adriengivry
force-pushed
the
feature/agnostic_scripting_backend
branch
2 times, most recently
from
8157d97 to
6580b00
Compare
adriengivry
force-pushed
the
feature/agnostic_scripting_backend
branch
from
6580b00 to
2eb0276
Compare
adriengivry
commented
Feb 16, 2025
adriengivry
commented
Feb 16, 2025
litelawliet
approved these changes
Feb 16, 2025
litelawliet
requested changes
Feb 16, 2025
Contributor
litelawliet
left a comment
litelawliet
left a comment
There was a problem hiding this comment.
A regression appaeared, the cursor still appears in Play Mode and doesn't allow us to move around or turn around anymore due to monitor constraints.
Member
Author
|
Fixed issue where |
litelawliet
approved these changes
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This rework will allow us to plug-in any type of scripting backend, such as Python!
Review Guidance
Tested with Lua and a new "Dummy" scripting backend (.ovscript), which does nothing, but you can still create scripts and add them as behaviour.
To-Do
PathParser.cppreference toluaextension (Follow up issue: MovePathParser::EFileTypeand its associated methods outside ofOvTools#358)(optional) test PyBindRelated Issues
Fixes #296