Fixed invalid default scene when created through the asset browser#369
Merged
adriengivry merged 1 commit intomainfrom Feb 15, 2025
Merged
Fixed invalid default scene when created through the asset browser#369adriengivry merged 1 commit intomainfrom
adriengivry merged 1 commit intomainfrom
Conversation
litelawliet
approved these changes
Feb 14, 2025
This was referenced Feb 16, 2025
Contributor
|
Introduced 2 regression bugs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Problem
Scenes created through the asset browser:
Create... > Sceneare "pre-generated" and "pre-serialized". However, this method forces us to update the serialized version of the default scene when our components change.This issue led to many errors showing up in the console when creating a scene through the asset browser, and then opening it.
Proposed Changes
This PR addresses this issue by adding some tools to create a default scene, and serialize it, when a default scene is requested by the asset browser. This new workflow also make it easier to maintain what a "default scene" should look like, as it is more consistent and shared between parts of the engine.
Notes
Also updated the
SceneManager::m_currentScenevariable type fromScene*tostd::unique_ptr<Scene*>to follow the RAII idiom.