Added function to trim leading/trailing whitespaces#372
Merged
litelawliet merged 5 commits intoOverload-Technologies:mainfrom Feb 15, 2025
Merged
Conversation
litelawliet
added
Bug
Critical
Trim static method added in OvTools::String and uses an enum for the trim type/direction. Added internal helpers to perform the leading or trailing trim.
litelawliet
force-pushed
the
fix/startup_scene_whitespaces_launch_crash
branch
from
d382fb0 to
419dfe1
Compare
adriengivry
requested changes
Feb 14, 2025
adriengivry
reviewed
Feb 14, 2025
adriengivry
reviewed
Feb 14, 2025
Co-authored-by: Adrien Givry <services@adrien-givry.com>
Co-authored-by: Adrien Givry <services@adrien-givry.com>
litelawliet
force-pushed
the
fix/startup_scene_whitespaces_launch_crash
branch
from
3eb2992 to
fd1034a
Compare
adriengivry
approved these changes
Feb 15, 2025
Member
adriengivry
left a comment
adriengivry
left a comment
There was a problem hiding this comment.
LGTM. Approved conditionally, provided that the spaces/tabs issues are fixed. We should only be using tabs
litelawliet
force-pushed
the
fix/startup_scene_whitespaces_launch_crash
branch
from
dd45eb0 to
15e48cb
Compare
litelawliet
force-pushed
the
fix/startup_scene_whitespaces_launch_crash
branch
from
15e48cb to
b14d692
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trim static method added in
OvTools::Stringand uses an structTrimOptionsfor the trim type/direction being left or right.Related Issues
Fixes #371.