make opencv fetch content-able #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehermvr
requested review from
saurabh1002 and
tizianoGuadagnino
as code owners
saurabh1002
approved these changes
Apr 12, 2024
Collaborator
saurabh1002
left a comment
saurabh1002
left a comment
There was a problem hiding this comment.
LGTM thanks very much @mehermvr
Collaborator
|
@mehermvr could you also remove the dependency from the README |
Member
Author
updated it. also indicated that eigen too is optional |
need some more testing and fix the README
tizianoGuadagnino
approved these changes
Apr 15, 2024
Collaborator
tizianoGuadagnino
left a comment
tizianoGuadagnino
left a comment
There was a problem hiding this comment.
Thanks everybody including @l00p3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opencv can be fetch content-ed as #6 tried to do.
HBST has a
#include <opencv2/opencv.hpp>which needs theOpenCV_INCLUDE_DIRSto be set manually.I've disabled a lot of stuff when building opencv, that probably needs a check.