This repository was archived by the owner on Jan 16, 2020. It is now read-only.
Closed
Conversation
NuttX doesn't seem to support CLOCK_MONOTONIC Signed-off-by: Mark Charlebois <charlebm@gmail.com>
LorenzMeier
pushed a commit
to PX4/PX4-Autopilot
that referenced
this pull request
May 23, 2016
See required DriverFramework change: PX4/DriverFramework#83 Signed-off-by: Mark Charlebois <charlebm@gmail.com>
| @@ -53,7 +53,7 @@ SyncObj::SyncObj() | |||
|
|
|||
| // QURT always uses CLOCK_MONOTONIC. | |||
Contributor
There was a problem hiding this comment.
I think we should update the commend here.
Contributor
|
The change looks correct (I checked the NuttX source), however, I think it would be good to update the comment. |
Signed-off-by: Mark Charlebois <charlebm@gmail.com>
Contributor
Author
|
@julianoes Let me know if you are happy with the updated comment on the use of CLOCK_MONOTONIC |
Contributor
|
Thanks for the comment fix @mcharleb, rebased and applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NuttX doesn't seem to support CLOCK_MONOTONIC
pthread_cond_timewait in NuttX uses CLOCK_REALTIME
Signed-off-by: Mark Charlebois charlebm@gmail.com