Filter airspeed before scaling servo torques#25224
Draft
mahima-yoga wants to merge 1 commit intomainfrom
Draft
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 184 byte (0.01 %)]px4_fmu-v6x [Total VM Diff: 184 byte (0.01 %)]Updated: 2025-11-13T15:55:02 |
dagar
reviewed
Aug 6, 2025
| _airspeed_filter_for_torque_scaling.reset(airspeed); | ||
|
|
||
| } else { | ||
| _airspeed_filter_for_torque_scaling.setParameters(dt, 1.f); |
Member
There was a problem hiding this comment.
At least add a comment explaining why the time constant is 1?
|
This pull request has been closed after being marked as stale with no further activity. Thank you for the time and effort you put into this contribution. If you’d like to continue the discussion or update the work, please feel free to reopen it or submit a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
When ... I found that ...
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes:
Alternatives
We could also ...
Test coverage
Context
Related links, screenshot before/after, video