Skip to content

Filter airspeed before scaling servo torques#25224

Draft
mahima-yoga wants to merge 1 commit intomainfrom
pr-airspeed_filtering
Draft

Filter airspeed before scaling servo torques#25224
mahima-yoga wants to merge 1 commit intomainfrom
pr-airspeed_filtering

Conversation

@mahima-yoga
Copy link
Contributor

Solved Problem

When ... I found that ...

Fixes #{Github issue ID}

Solution

  • Add ... for ...
  • Refactor ...

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...

Alternatives

We could also ...

Test coverage

Context

Related links, screenshot before/after, video

@github-actions
Copy link

github-actions bot commented Jul 15, 2025

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 184 byte (0.01 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +184  +0.0%    +184    .text
   +74%    +160   +74%    +160    FixedwingRateControl::get_airspeed_and_update_scaling()
  +0.9%     +16  +0.9%     +16    FixedwingRateControl::FixedwingRateControl()
  +0.0%      +8  +0.0%      +8    [section .text]
+0.0%     +89  [ = ]       0    .debug_abbrev
+0.0%     +32  [ = ]       0    .debug_frame
+0.0% +8.61Ki  [ = ]       0    .debug_info
+0.0%    +396  [ = ]       0    .debug_line
 -40.0%      -2  [ = ]       0    [Unmapped]
  +0.0%    +398  [ = ]       0    [section .debug_line]
+0.0%    +284  [ = ]       0    .debug_loclists
+0.0%     +92  [ = ]       0    .debug_rnglists
+0.0%     +36  [ = ]       0    .debug_str
-1.8%    -184  [ = ]       0    [Unmapped]
+0.0% +9.52Ki  +0.0%    +184    TOTAL

px4_fmu-v6x [Total VM Diff: 184 byte (0.01 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +184  +0.0%    +184    .text
   +74%    +160   +74%    +160    FixedwingRateControl::get_airspeed_and_update_scaling()
  +0.9%     +16  +0.9%     +16    FixedwingRateControl::FixedwingRateControl()
  +0.0%      +8  +0.0%      +8    [section .text]
+0.0%     +89  [ = ]       0    .debug_abbrev
+0.0%     +32  [ = ]       0    .debug_frame
+0.0% +8.61Ki  [ = ]       0    .debug_info
+0.0%    +396  [ = ]       0    .debug_line
  [DEL]      -2  [ = ]       0    [Unmapped]
  +0.0%    +398  [ = ]       0    [section .debug_line]
+0.0%    +260  [ = ]       0    .debug_loclists
+0.0%     +92  [ = ]       0    .debug_rnglists
+0.0%     +36  [ = ]       0    .debug_str
-3.1%    -184  [ = ]       0    [Unmapped]
+0.0% +9.50Ki  +0.0%    +184    TOTAL

Updated: 2025-11-13T15:55:02

_airspeed_filter_for_torque_scaling.reset(airspeed);

} else {
_airspeed_filter_for_torque_scaling.setParameters(dt, 1.f);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least add a comment explaining why the time constant is 1?

@github-actions github-actions bot added the stale label Sep 13, 2025
@github-actions
Copy link

This pull request has been closed after being marked as stale with no further activity. Thank you for the time and effort you put into this contribution. If you’d like to continue the discussion or update the work, please feel free to reopen it or submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants