Properly remove items from shelves - #13567
Merged
Merged
Conversation
lynxplay
approved these changes
Jan 24, 2026
lynxplay
left a comment
lynxplay
left a comment
Contributor
There was a problem hiding this comment.
Works ish however the chiseled bookshelf has this incredibly annoying implementation detail of using block state to track its visual instead of the BE itself, which means that the code suggested by every guide and post on this planet (call your local BlockState#update() method after modification) will still lead to this visual break from the actual BE state.
I don't think there is anything sane we can do against this however.
Owen1212055
approved these changes
Apr 12, 2026
Lulu13022002
force-pushed
the
fix/shelves-inventory
branch
from
April 30, 2026 18:31
4886980 to
d4494f9
Compare
Lulu13022002
force-pushed
the
fix/shelves-inventory
branch
from
August 5, 2026 18:37
d4494f9 to
e250396
Compare
Lulu13022002
enabled auto-merge (squash)
August 5, 2026 18:41
github-project-automation
Bot
moved this from Awaiting review
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved version of https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/a32e32b49200c6b8a64eea0a7bf2140167e7550c covering the shelf too.