Only scan world if Villager profession has secondary POI

[Phoenix616]

In Vanilla all Villagers query (and potentially even load) all blocks in a 9x5x9 area around them via the SecondaryPoiSensor to search for valid secondary POIs even though most Villagers don't actually search for any. Only the profession "farmer" searches for a secondary POI (the farmland) in Vanilla making these.

As not the full logic can be seen in the patch, here is the unnecessary loop which is disabled unless the Villager's profession has secondary POI set:

        for (int x = -4; x <= 4; x++) {
            for (int y = -2; y <= 2; y++) {
                for (int z = -4; z <= 4; z++) {
                    BlockPos testPos = center.offset(x, y, z);
                    if (body.getVillagerData().profession().value().secondaryPoi().contains(level.getBlockState(testPos).getBlock())) {
                        jobSites.add(GlobalPos.of(dimensionType, testPos));
                    }
                }
            }
        }

        Brain<?> brain = body.getBrain();
        if (!jobSites.isEmpty()) {
            brain.setMemory(MemoryModuleType.SECONDARY_JOB_SITE, jobSites);
        } else {
            brain.eraseMemory(MemoryModuleType.SECONDARY_JOB_SITE);
        }

In order to keep the rest of the logic with the memory intact only this loop is disabled, not the whole sensor.

[electronicboy]

This doesn't need to run the memory erasal logic?

[Phoenix616]

I'm unsure if I understand your question correctly. The memory erasure logic is still run (as the jobSites list will be empty) after the loop in order to guard against the case where the profession of a Villager or the secondaryPoi set of a profession changes without the SECONDARY_JOB_SITE memory being cleared. (I included the logic of the erasure now in the code block in the PR description)

[electronicboy]

I blame my lack of sleep

[kennytv]

for tracking purposes

[MartijnMuijsers]

Was already done in Lithium:

https://github.com/CaffeineMC/lithium/blob/c42972b6e9d21c8ff45559df6b271802050a22e2/common/src/main/java/net/caffeinemc/mods/lithium/mixin/ai/sensor/secondary_poi/SecondaryPoiSensorMixin.java#L13

Not sure if taken from it, but just mentioning the credit.

[Phoenix616]

Was already done in Lithium:

CaffeineMC/lithium@c42972b/common/src/main/java/net/caffeinemc/mods/lithium/mixin/ai/sensor/secondary_poi/SecondaryPoiSensorMixin.java#L13

Not sure if taken from it, but just mentioning the credit.

TIL. Good to know I'm not the only one coming to this conclusion but this was discovered independently while writing up this blog post.