Added Gradle config to README, updated dep version by BomBardyGamer · Pull Request #3699 · PaperMC/Paper

BomBardyGamer · 2020-06-29T18:49:47Z

Okay I believe I've got everything right this time, or as one would say, I nailed it. I've added a section to the README that shows an example of how to depend on the Paper API with Gradle, to help developers who choose Gradle over Maven. I've also updated the <version> tag in the Maven section and set the version in my new Gradle guide to 1.16.1-R0.1-SNAPSHOT (as it should be), from 1.15.2-R0.1-SNAPSHOT.

Again, please let me know if I screwed something up.

Fixes #3610 Fixes #3611

Fixes #3637

kennytv · 2020-06-29T19:16:09Z

 DoNotSpamPls <7570108+DoNotSpamPls@users.noreply.github.com>
 JRoy <joshroy126@gmail.com>
 Robert Norman <spottedleaf@spottedleaf.dev>, <Spottedleaf@users.noreply.github.com>
+Callum Seabrook <callum.seabrook@prevarinite.com>


Incredible.

Well, thought I might as well as I'm more than happy to license this under MIT

mdcfe · 2020-06-29T19:17:45Z

    <groupId>com.destroystokyo.paper</groupId>
    <artifactId>paper-api</artifactId>
-    <version>1.15.2-R0.1-SNAPSHOT</version>
+    <version>1.16.1-R0.1-SNAPSHOT</version>


The master branch is not 1.16.1.

Fixed, reverted back to 1.15.2-R0.1-SNAPSHOT, my bad.

mdcfe · 2020-06-29T19:17:57Z

+ * Artifact:
+```groovy
+dependencies {
+    compileOnly('com.destroystokyo.paper:paper-api:1.16.1-R0.1-SNAPSHOT')


Same as above.

BomBardyGamer · 2020-06-29T19:19:35Z

Yeah you're right. Time for attempt 4?

mdcfe · 2020-06-29T19:20:52Z

You know you don't need to keep creating new PRs, right? You can push new commits to existing PR branches and it will update the PR, and the Paper team can squash these commits down to a single commit if they decide to merge your PR.

wizjany · 2020-06-29T19:21:10Z

please stop closing and re-opening new pull requests. it creates unnecessary spam. you can continue adding commits to this PR, and squash if needed.

edit: md ninja'd me

JRoy

master isn't 1.16 yet, so targeting the master branch here is wrong. Also, you aren't providing patches so don't add your name to the LICENSE.md since the readme isn't code

JRoy · 2020-06-29T19:20:06Z

+```groovy
+repositories {
+    maven {
+        url('https://papermc.io/repo/repository/maven-public/')


Suggested change

url('https://papermc.io/repo/repository/maven-public/')

url 'https://papermc.io/repo/repository/maven-public/'

Same as below

JRoy · 2020-06-29T19:21:19Z

+ * Artifact:
+```groovy
+dependencies {
+    compileOnly('com.destroystokyo.paper:paper-api:1.16.1-R0.1-SNAPSHOT')


Suggested change

compileOnly('com.destroystokyo.paper:paper-api:1.16.1-R0.1-SNAPSHOT')

compileOnly 'com.destroystokyo.paper:paper-api:1.16.1-R0.1-SNAPSHOT'

That actually wasn't my idea, it was suggested by @Proximyst

JRoy · 2020-06-29T19:21:28Z

 DoNotSpamPls <7570108+DoNotSpamPls@users.noreply.github.com>
 JRoy <joshroy126@gmail.com>
 Robert Norman <spottedleaf@spottedleaf.dev>, <Spottedleaf@users.noreply.github.com>
+Callum Seabrook <callum.seabrook@prevarinite.com>


Suggested change

Callum Seabrook <callum.seabrook@prevarinite.com>

What's the issue with that? I thought you just had to put your name in there to license your stuff under MIT... or am I missing something.

YOU. CANNOT. LICENSE. YOUR. CHANGES. TO. THE. README. IT'S. ONLY. PATCHES.

Yours truly licensing 10 lines of generic important statements

Okay, okay, I'll change it hold on. Didn't know, my apologies.

BomBardyGamer · 2020-06-29T19:24:58Z

please stop closing and re-opening new pull requests. it creates unnecessary spam. you can continue adding commits to this PR, and squash if needed.

edit: md ninja'd me

Didn't know that until I googled it a minute ago, thanks

BomBardyGamer · 2020-06-29T19:30:03Z

Should all be fixed now, let me know if you guys find anything else 🙂

JRoy · 2020-06-29T19:30:30Z

You're still targeting master, needs to target ver/1.16

BomBardyGamer · 2020-06-29T19:31:51Z

My apologies, how do I change the branch on existing commits? or do I have to revert and re-commit

DenWav · 2020-06-29T19:33:55Z

You can't change the branch a PR is targeting. You have to open a new PR.

DenWav · 2020-06-29T19:34:33Z

Apparently I was wrong. That's neat.

zachbr · 2020-06-29T19:35:01Z

I just changed the base, but you'll have to fix some of the conflicts that snuck in somehow?
I think all you care about is the readme.

BomBardyGamer · 2020-06-29T19:36:05Z

Okay thanks, yeah the commits are all over the place since I had to fix a couple of things I screwed up in the initial commit. Any idea how to change those commits?

kennytv · 2020-06-29T19:38:46Z

Search for resetting, rebasing, and force-pushing

clrxbl · 2020-06-29T19:39:06Z

bruh moment

BomBardyGamer · 2020-06-29T19:40:27Z

Okay, so I've gotta reset the commits back to the latest commit from Aikar, then re-commit on the ver/1.16 branch. On it.

The only problem with that is if I reset softly it seems to give me many patch files that just apparently don't count as having been committed any more.

kennytv · 2020-06-29T19:42:56Z

Hard reset and do a new commit with your changes then, shouldn't be too hard to copy paste a bunch of text again

BomBardyGamer · 2020-06-29T19:43:47Z

Still seems to give me like 6 locally changed files if I hard reset to the latest commit before mine. 🤔

BomBardyGamer · 2020-06-29T19:47:58Z

Just me being stupid and trying to reset back to the ver/1.16 branch

BomBardyGamer · 2020-06-29T19:53:13Z

Sorted. Am I gonna need a new PR to change the merge branch?

zachbr · 2020-06-29T19:53:52Z

No, just make sure that it looks how you want locally and force push over this branch.

BomBardyGamer · 2020-06-29T19:54:25Z

Can't seem to change the branch it's merging from, since my commit is now on ver/1.16 on my fork.

aikar and others added 5 commits June 25, 2020 04:01

Fix NPE and uuid lookup for player skulls

a8ffecc

Fixes #3610 Fixes #3611

Revert recent changes around player skulls using user cache

5fc45f4

Fixes #3637

Manually inline PooledBlockPosition#d(int, int, int)

1d1c056

[1.15] Fix MobGoals#getAllGoals not actually returning all goals (#3671)

3fc9899

Fix Player Profile textures being duplicated - Fixes #3667

49491f3

kennytv reviewed Jun 29, 2020

View reviewed changes

mdcfe suggested changes Jun 29, 2020

View reviewed changes

JRoy suggested changes Jun 29, 2020

View reviewed changes

zachbr changed the base branch from master to ver/1.16 June 29, 2020 19:34

BomBardyGamer closed this Jun 29, 2020

BomBardyGamer reopened this Jun 29, 2020

BomBardyGamer closed this Jun 29, 2020

PaperMC locked and limited conversation to collaborators Jun 29, 2020

	url('https://papermc.io/repo/repository/maven-public/')
	url 'https://papermc.io/repo/repository/maven-public/'

	compileOnly('com.destroystokyo.paper:paper-api:1.16.1-R0.1-SNAPSHOT')
	compileOnly 'com.destroystokyo.paper:paper-api:1.16.1-R0.1-SNAPSHOT'

Uh oh!

Conversation

BomBardyGamer commented Jun 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

mdcfe commented Jun 29, 2020

Uh oh!

wizjany commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JRoy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

JRoy commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

DenWav commented Jun 29, 2020

Uh oh!

DenWav commented Jun 29, 2020

Uh oh!

zachbr commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

kennytv commented Jun 29, 2020

Uh oh!

clrxbl commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytv commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020

Uh oh!

zachbr commented Jun 29, 2020

Uh oh!

BomBardyGamer commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wizjany commented Jun 29, 2020 •

edited

Loading

BomBardyGamer commented Jun 29, 2020 •

edited

Loading

BomBardyGamer commented Jun 29, 2020 •

edited

Loading