perf(minimessage): add system property to skip tag validation - #1438
Closed
ProdPreva1l wants to merge 1 commit into
Closed
perf(minimessage): add system property to skip tag validation#1438ProdPreva1l wants to merge 1 commit into
ProdPreva1l wants to merge 1 commit into
Conversation
|
That looks like a problem with GraalVM. Can you provide a spark profile using HotSpot/C2? If there is a problem with excessive allocations, I think it would be better to implement the validation manually instead of relying on |
Author
|
Here's with just C2 via Zulu. A very slight improvement. |
Member
Agreed. I'm going to close this because of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a system property intended for use by advanced users who are confident that they are using valid minimessage tags.
This has a very small usecase but a pretty major impact.
https://spark.lucko.me/Aqo35xCxyT?hl=8160
As seen in this spark at the linked method call, its allocation rate is about 650kbps which is quite high for what the call does and adds up.