Add crafting for Subsume the Source - #10109
Merged
Merged
Conversation
added 3 commits
August 4, 2026 16:32
Use `CanHaveMod` consistently for affix eligibility Use alternate base tags only when configured Remove Crimson Storm’s invalid base override Simplify rare like affix limits and option names Restore modifier metadata on duplicate tooltip lines Remove unrelated item-base annotations Add regression tests for the corrected behavior
LocalIdentity
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR adds support for Subsume the Source, which is an unique which can have abyss jewel modifiers. This originally tried to add it as a big variant, and so this also contains the Megablood duplicate variant code from PoB2. This is admittedly now completely unrelated, but it should probably be ported anyway and so I've not removed it here.
Subsume the Source has its sockets fixed to not add useless abyss sockets.
The unique crafting should work with advanced copy items. It also has a dummy
Crafted: trueline in the unique DB which means it should work from there.Another example I've added here is crimson storm. The unique db item had to have Suffix: None added to it
This is based on #10105, and it actually has that as the base branch
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: