Skip to content

Add crafting for Subsume the Source - #10109

Merged
LocalIdentity merged 6 commits into
PathOfBuildingCommunity:devfrom
vaisest:abyss-helmet
Aug 4, 2026
Merged

Add crafting for Subsume the Source#10109
LocalIdentity merged 6 commits into
PathOfBuildingCommunity:devfrom
vaisest:abyss-helmet

Conversation

@vaisest

@vaisest vaisest commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This PR adds support for Subsume the Source, which is an unique which can have abyss jewel modifiers. This originally tried to add it as a big variant, and so this also contains the Megablood duplicate variant code from PoB2. This is admittedly now completely unrelated, but it should probably be ported anyway and so I've not removed it here.

Subsume the Source has its sockets fixed to not add useless abyss sockets.

The unique crafting should work with advanced copy items. It also has a dummy Crafted: true line in the unique DB which means it should work from there.

Another example I've added here is crimson storm. The unique db item had to have Suffix: None added to it

This is based on #10105, and it actually has that as the base branch

Steps taken to verify a working solution:

  • Nothing so far

Link to a build that showcases this PR:

Item Class: Helmets
Rarity: Unique
Subsume the Source
Faithful Helmet
--------
Armour: 269
Energy Shield: 54
--------
Requirements:
Level: 73
Str: 101
Int: 101
--------
Item Level: 86
--------
{ Prefix Modifier "Scorching" — Damage, Elemental, Fire, Attack  — 210% Increased }
10(9-11) to 16(16-19) Added Fire Damage with Sword Attacks
{ Unique Modifier  — 210% Increased }
210(120-240)% increased Explicit Modifier magnitudes
{ Unique Modifier  — 210% Increased }
Cannot have non-Abyssal sockets
{ Suffix Modifier "of Unholy Might"  — 210% Increased }
3(3-5)% chance to Gain Unholy Might for 4 seconds on Melee Kill
(Unholy Might grants 100% of Physical Damage converted to Chaos Damage and 25% chance to apply Withered on Hit)
{ Suffix Modifier "of Adaption" (Tier: 1) — Attribute  — 210% Increased }
+7(6-8) to all Attributes
(Attributes are Strength, Dexterity, and Intelligence)
{ Suffix Modifier "of the Inferno" — Damage, Physical, Elemental, Fire  — 210% Increased }
Gain 3(2-4)% of Physical Damage as Extra Fire Damage if you've dealt a Critical Strike Recently
(Recently refers to the past 4 seconds)
--------
A lich may lust for vengeance, power,
darkness, or dominion, but it is their
nature. They can never be satisfied.
--------
Note: ~b/o 100 chaos
Item Class: Bows
Rarity: Unique
The Crimson Storm
Steelwood Bow
--------
Bow
Physical Damage: 98-145 (augmented)
Critical Strike Chance: 7.37% (augmented)
Attacks per Second: 1.40
--------
Requirements:
Level: 57
Dex: 190 (unmet)
--------
Sockets: W-W W W 
--------
Item Level: 85
--------
{ Implicit Modifier — Speed }
6% increased Movement Speed
--------
{ Unique Modifier — Damage, Physical, Attack }
69(60-80)% increased Physical Damage
{ Unique Modifier — Attack, Critical }
34(25-35)% increased Critical Strike Chance
{ Unique Modifier — Physical, Attack, Critical, Ailment }
50% chance to inflict Bleeding on Critical Strike with Attacks
(Bleeding deals Physical Damage over time, based on the base Physical Damage of the Skill. Damage is 200% higher while moving)
{ Unique Modifier }
Enemies you inflict Bleeding on grant 66(60-100)% increased Flask Charges
{ Unique Modifier — Damage, Physical }
Adds 104(100-120) to 163(150-165) Physical Damage against Bleeding Enemies
{ Unique Modifier — Critical }
50% chance to Maim Enemies on Critical Strike with Attacks
(Maimed enemies have 30% reduced Movement Speed)
{ Suffix Modifier "of the Order" (Tier: 1) — Damage, Physical }
+24(24-28)% to Physical Damage over Time Multiplier
--------
"There were no survivors. It had only been fired twice."
- Order of the Djinn inscription

Before screenshot:

After screenshot:

image

LocalIdentity added 3 commits August 4, 2026 16:32
Use `CanHaveMod` consistently for affix eligibility
Use alternate base tags only when configured
Remove Crimson Storm’s invalid base override
Simplify rare like affix limits and option names
Restore modifier metadata on duplicate tooltip lines
Remove unrelated item-base annotations
Add regression tests for the corrected behavior
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Aug 4, 2026
@LocalIdentity LocalIdentity changed the title Abyss helmet Add crafting for Subsume the Source Aug 4, 2026
@LocalIdentity
LocalIdentity marked this pull request as ready for review August 4, 2026 08:37
@LocalIdentity
LocalIdentity merged commit 9e6ea22 into PathOfBuildingCommunity:dev Aug 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants