Fix globalLimit being sensitive to tag order#8652
Merged
LocalIdentity merged 16 commits intoPathOfBuildingCommunity:devfrom Jun 13, 2025
Merged
Fix globalLimit being sensitive to tag order#8652LocalIdentity merged 16 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 16 commits intoPathOfBuildingCommunity:devfrom
Conversation
your overcapped Fire Resistance"
…qual to 15% of your Maximum Life"
When a mod gots pice wise parsed the tags can be added to the mod table in unpredictable order. The inital implementation was simply checking the first tag which caused the global limit functionality to not work sometimes. This commit moves the logic into EvalMod.
… into merc-uniques
LocalIdentity
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue i found with #8619
Description of the problem being solved:
globalLimit style tags were sensitive to tag ordering with caused issues with piece wise mods that add tags through
modFlagListSteps taken to verify a working solution:
See added test