Skip to content

Fix item modifier classification on character import#9993

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
czarandy:fix/item-mod-flags-import
Jul 25, 2026
Merged

Fix item modifier classification on character import#9993
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
czarandy:fix/item-mod-flags-import

Conversation

@czarandy

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Path of Exile 3.29 moved the crafted, fractured, and mutated classification fields under ItemMod.flags. The 3.29 import update reads those fields directly from ItemMod, so imported modifiers retain their text but lose their classification.

Read the nested flags object while retaining the existing fallback for older string/top-level modifier shapes.

Steps taken to verify a working solution:

  • Added regression coverage using the 3.29 ItemMod response shape.
  • Verified the test checks crafted, fractured, and mutated classifications after the imported item's raw rebuild/parse cycle.
  • Ran git diff --check.
  • Busted was not run locally because Docker Desktop's WSL integration and a local LuaJIT/Busted installation were unavailable.

Link to a build that showcases this PR:

N/A — character import data handling only.

Before screenshot:

N/A

After screenshot:

N/A

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jul 25, 2026
@LocalIdentity
LocalIdentity merged commit b05b2ae into PathOfBuildingCommunity:dev Jul 25, 2026
3 checks passed
DrakenKor pushed a commit to DrakenKor/PathOfBuilding that referenced this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants