fix unwanted copies of return values

[Max Bachmann (maxbachmann)]

Update public API return types to avoid returning by const value. This improves usability since callers can modify or move the returned value.

In addition this avoids an unnecessary copy of the m_configSettings hashmap while under the config mutex

[Max Bachmann (maxbachmann)]

Edit: Thinking about this a bit more this was probably supposed to guard against the config hashmap getting modified.

I cleaned this up in a couple of ways:

• return by value instead of const value
• remove outdated static empty string that doesn't serve any purpose anymore
• avoid unnecessary copy of the config hashmap when getting the log / shared content directory

[Max Bachmann (maxbachmann)]

ping tculotta Dimitris Gkanatsios (@dgkanatsios) Nassos Terzakis (@nassosterz-ms)

[Max Bachmann (maxbachmann)]

Ping Dimitris Gkanatsios (@dgkanatsios) Warren Alpert (@WarrenAlpert) Brian Porter (@brianwp3000)

[Dimitris Gkanatsios (dgkanatsios)]

Really sorry for the delay, team has been really busy. Promise to take a look as fast as we can!

[Raul Gomez Rodriguez (rgomez391)]

Max Bachmann (@maxbachmann) just one minor note: The PR description ("supposed to return a const reference") is slightly misleading — the fix actually makes them return non-const values by value, which is the correct approach.

[Raul Gomez Rodriguez (rgomez391)]

The code looks correct to me and I verified that there are no compilation issues.

[Copilot]

Pull request overview

Updates the C++ GSDK public API return types to avoid top-level const on return-by-value results, improving usability (callers can mutate the returned value) and enabling move semantics where applicable.

Changes:

• Remove top-level const from return-by-value APIs (getConfigSettings, getLogsDirectory, getSharedContentDirectory) in the public header and implementation.
• Avoid an extra copy of m_configSettings inside getLogsDirectory / getSharedContentDirectory by referencing the internal map under the config mutex.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
cpp/cppsdk/gsdk.h	Updates public API signatures to remove top-level const on return-by-value types.
cpp/cppsdk/gsdk.cpp	Matches updated signatures and reduces internal copying when reading config values.

[Dimitris Gkanatsios (dgkanatsios)]

merging, thanks for the contribution Max Bachmann (@maxbachmann) !