fix: align wire keys with mosaicod 0.6.x servers - #2
Merged
Conversation
The query filter identity key was renamed locator -> name server-side (mosaicod #565); a stale "locator" key silently matches nothing against current mosaicod. Emit "name" from QueryTopicBuilder/QuerySequenceBuilder withName/withNameMatch. The streaming ticket descriptor still uses resource_locator and is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SessionAppMetadata identifies sessions by "locator" since mosaicod 0.6.0 (#584 dropped the uuid); older servers sent "uuid". Parse both, preferring the current key, and rename SessionInfo::uuid to locator (the struct has no active consumers). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTJvEsHX26rG4cHmqppvQg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the client with mosaicod >= 0.6.0 (released 2026-08-07), verified against the v0.6.0 server marshaling sources (
mosaicod-marshal/src/{query,flight}.rs,actions/{requests,responses}.rs):nameidentity key (mosaicod #565). The oldlocatorkey silently matches nothing against current servers — no error, empty results.QueryTopicBuilder/QuerySequenceBuilder::withName/withNameMatchnow emitname; the streaming ticket'sresource_locatoris deliberately unchanged (only the query filter key was renamed).locatoridentity (mosaicod #584 droppeduuidfromSessionAppMetadata). The parser preferslocatorand still acceptsuuidfrom older servers;SessionInfo::uuidis renamed tolocator(the struct has no active consumers).Everything else this client touches was verified unchanged in 0.6.0:
resource_locatorin FlightInfo descriptors/tickets, notification action names andlocatorpayload key, the{"sequence"/"topic": {...}}query envelope, endpointinfo.{total_bytes,timestamp}parsing, and theversionaction.Validated downstream: pj-official-plugins builds toolbox_mosaico against this exact revision (
fcbaa3a) with the revision-pinned active-pull-cancel patch applying cleanly; 26/26 plugin tests pass (pj-official-plugins PR #287).fcbaa3aby SHA (CPM zip URL); a squash/rebase would orphan it and 404 the downstream build.🤖 Generated with Claude Code
https://claude.ai/code/session_01TTJvEsHX26rG4cHmqppvQg