Skip to content

Tweaks to CMake passthrough, small fixes in prep for mac and windows #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2024
Merged

Tweaks to CMake passthrough, small fixes in prep for mac and windows #162

merged 2 commits into from
Mar 21, 2024

Conversation

@timkpaine
Copy link
Member

@timkpaine timkpaine commented Mar 20, 2024

  • Tweak CMake flag passthrough from setup.py
    • configure various CMake flags and adapter builds via outer env vars
  • fix macos platform target and remove soon-to-be-unnecessary ld_classic flags
    • out C++ code requires 10.15
    • ld_classic won't be necessary
    • fix missing header that causes a problem exposed by the above changes
  • fix windows vcpkg initialization in preparation for windows build
  • Update CODEOWNERS for files that people may be less familiar with, where changes may be problematic

@timkpaine timkpaine added the part: build Issues and PRs related to the build process label Mar 20, 2024
timkpaine
timkpaine commented Mar 20, 2024
View reviewed changes
@timkpaine timkpaine marked this pull request as draft March 20, 2024 16:30
@timkpaine
Tweak CMake flag passthrough from setup.py, fix macos platform target…
bbd986f 
… and remove soon-to-be-unnecessary ld_classic flags, fix missing header, fix windows vcpkg initialization in preparation for windows build

Fix FindCSP for math library, remove vestigial path from findcsp_autogen cmake helper
Turn off C++ tests, will do in separate PR

Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com>
@timkpaine timkpaine mentioned this pull request Mar 20, 2024
Merged
robambalu
robambalu reviewed Mar 20, 2024
View reviewed changes
@timkpaine
Update codeowners with qs folks
382dbf9 
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com>
@timkpaine timkpaine marked this pull request as ready for review March 20, 2024 19:33
@timkpaine
Copy link
Member Author

timkpaine commented Mar 21, 2024

full build https://github.com/Point72/csp/actions/runs/8379505762

@timkpaine timkpaine merged commit 7ff7719 into main Mar 21, 2024
@timkpaine timkpaine deleted the tkp/setuppy branch March 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robambalu robambalu robambalu approved these changes

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

+1 more reviewer

@czgdp1807 czgdp1807 czgdp1807 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

part: build Issues and PRs related to the build process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timkpaine @robambalu @czgdp1807