Skip to content

Re-enable C++ testing #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2024
Merged

Re-enable C++ testing #163

merged 3 commits into from
Mar 25, 2024

Conversation

@timkpaine
Copy link
Member

@timkpaine timkpaine commented Mar 20, 2024

Depends on #162 to avoid conflicts

  • Re-enable C++ tests
  • Build C++ tests by default
  • Run C++ tests by default via make build command

Note: I was lazy and used a bash for loop. Windows will probably be unhappy.

@timkpaine timkpaine added part: tests Issues and PRs related to tests lang: c++ Issues and PRs related to the C++ codebase labels Mar 20, 2024
@timkpaine timkpaine force-pushed the tkp/cpptests branch 2 times, most recently from 96e0727 to 61afe11 Compare March 20, 2024 18:45
@timkpaine timkpaine marked this pull request as ready for review March 21, 2024 19:12
@timkpaine timkpaine force-pushed the tkp/cpptests branch 2 times, most recently from 785b749 to c5e2894 Compare March 21, 2024 19:14
@timkpaine
Enable c++ tests
d19fd99 
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com>
robambalu
robambalu reviewed Mar 21, 2024
View reviewed changes
@timkpaine
Redo some changes after bad merge
d9fbfb1 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
robambalu
robambalu previously approved these changes Mar 21, 2024
View reviewed changes
@timkpaine timkpaine added the tag: needs squash PRs that need to be cleaned/squashed label Mar 21, 2024
@timkpaine
Remove rt linkage, also dropped during bad merge
f3065f4 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine
Copy link
Member Author

timkpaine commented Mar 22, 2024

full build: https://github.com/Point72/csp/actions/runs/8383326338

@timkpaine timkpaine merged commit aa3e18a into main Mar 25, 2024
@timkpaine timkpaine deleted the tkp/cpptests branch March 25, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robambalu robambalu robambalu approved these changes

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees

No one assigned

Labels

lang: c++ Issues and PRs related to the C++ codebase part: tests Issues and PRs related to tests tag: needs squash PRs that need to be cleaned/squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timkpaine @robambalu