Skip to content

Add dockerfiles for testing before release#3995

Merged
kunaltyagi merged 23 commits intoPointCloudLibrary:masterfrom
kunaltyagi:release
May 11, 2020
Merged

Add dockerfiles for testing before release#3995
kunaltyagi merged 23 commits intoPointCloudLibrary:masterfrom
kunaltyagi:release

Conversation

@kunaltyagi
Copy link
Member

@kunaltyagi kunaltyagi commented Apr 29, 2020

  • Adds a dockerfile for building PCL on debian:testing
  • Adds a dockerfile for building PCL and perception_pcl on kinetic and melodic flavors of ROS
  • Adds a CI to perform some tasks of the release with a manual trigger
  • Kinetic perception_pcl is broken since 1.10, and can't be targeted by PCL
  • Tested manually for melodic

Offshoots of this PR:

TODO after this PR:

  • Test CI

@kunaltyagi kunaltyagi added help wanted skill: azure Skills/areas of expertise needed to tackle the issue module: ci needs: more work Specify why not closed/merged yet labels Apr 29, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.11.0 milestone Apr 29, 2020
@kunaltyagi
Copy link
Member Author

Need help testing the dockerfiles

@jspricke
Copy link
Member

Note that perception_pcl is in Debian (testing), so you could go with apt source -b ros-perception-pcl

@kunaltyagi
Copy link
Member Author

kunaltyagi commented May 2, 2020

Azure is running out of disk space for compiling PCL on debian:testing

@kunaltyagi
Copy link
Member Author

kunaltyagi commented May 4, 2020

PR opened (ros-perception/perception_pcl#273) to make sure downstream target pcl_ros works after the smart pointer API break.

All images have been verified manually (not on CI) before the API break

EDIT:
Since the mentioned PR has been merged, Dockerfile has been tested after the break with melodic

@kunaltyagi
Copy link
Member Author

kunaltyagi commented May 6, 2020

Should I remove the commented code? The plan was to test it in this PR, but my account's CI doesn't have enough space to build PCL

Once merged, we can test it on PCL's CI with increased memory quota. Speaking of which @taketwo could you please contact Azure to increase CI space just a bit more so Windows doesn't OOM out randomly.

@kunaltyagi kunaltyagi marked this pull request as ready for review May 6, 2020 06:44
@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet status: needs upstream fix labels May 6, 2020
@kunaltyagi kunaltyagi mentioned this pull request May 6, 2020
9 tasks
@taketwo
Copy link
Member

taketwo commented May 6, 2020

could you please contact Azure to increase CI space just a bit more so Windows doesn't OOM out randomly

They said they have to technical possibility to increase the space.

@kunaltyagi
Copy link
Member Author

They said they have to

Did you mean "They said they have no" instead?

@taketwo
Copy link
Member

taketwo commented May 6, 2020

Yep, no technical possibility, sorry. To quote their answer:

We do not have the ability to increase the free disk space limit on hosted machines. Everyone in free tier and paid tier get the same free disk space.

@kunaltyagi
Copy link
Member Author

Got it. In which case, I guess we see what happens after this gets reviewed, merged and a new pipeline is created.

@kunaltyagi kunaltyagi removed help wanted skill: azure Skills/areas of expertise needed to tackle the issue labels May 6, 2020
@kunaltyagi kunaltyagi changed the title Add dockerfiles to test before release Add dockerfiles for testing before release May 6, 2020
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to generate source tarball manually? One can always download a tarball for a tag/release from GitHub.

@kunaltyagi
Copy link
Member Author

Yes. That's sadly needed because the GitHub interface isn't quite the same as the GitHub task on Azure CI. I tried with not uploading a source, but then the release didn't have anything

@kunaltyagi
Copy link
Member Author

Merging to start testing with PCL's pipeline instead of mine

@kunaltyagi kunaltyagi merged commit 00be28d into PointCloudLibrary:master May 11, 2020
@kunaltyagi kunaltyagi deleted the release branch May 11, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: ci needs: code review Specify why not closed/merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants