Add tutorial for creating custom executors#4359
Add tutorial for creating custom executors#4359shrijitsingh99 wants to merge 5 commits intoPointCloudLibrary:masterfrom
Conversation
kunaltyagi
left a comment
kunaltyagi
left a comment
There was a problem hiding this comment.
Please format the cpp file (eg: std::cout << notice the added spaces between different literals)
Also, CMakeLists.txt is missing
doc/tutorials/content/sources/custom_executor/custom_executor.cpp
Outdated
Show resolved
Hide resolved
doc/tutorials/content/sources/custom_executor/custom_executor.cpp
Outdated
Show resolved
Hide resolved
SergioRAgostinho
added
module: tutorials
priority: gsoc
|
|
||
| .. note:: | ||
| This is an advanced topic and requires some knowledge on working of executors | ||
| and its implementation in PCL. |
There was a problem hiding this comment.
Is there any location at the moment to where we can point the reader for additional info?
There was a problem hiding this comment.
The idea was to link them to the design document and Code API.
Both are yet to be merged.
There was a problem hiding this comment.
Create an issue to link them (in your fork or PCL) so we don't forget
doc/tutorials/content/sources/custom_executor/custom_executor.cpp
Outdated
Show resolved
Hide resolved
doc/tutorials/content/sources/custom_executor/custom_executor.cpp
Outdated
Show resolved
Hide resolved
doc/tutorials/content/sources/custom_executor/custom_executor.cpp
Outdated
Show resolved
Hide resolved
| // Forward declaration for custom executor | ||
| template <typename Blocking, typename ProtoAllocator> | ||
| struct omp_benchmark_executor; |
There was a problem hiding this comment.
Is this forward declaration required? What happens if you move the is_executor_available after the class is defined?
There was a problem hiding this comment.
It is needed since we check for this inside the class:
static_assert(is_executor_available_v<omp_executor>, "OpenMP benchmark executor unavailable");There was a problem hiding this comment.
That static assert checks for omp_executor, not omp_benchmark_executor
There was a problem hiding this comment.
Oops. Fixed now.
|
Made the requested changes. Rendered Preview
|
|
|
||
| .. note:: | ||
| This is an advanced topic and requires some knowledge on working of executors | ||
| and its implementation in PCL. |
There was a problem hiding this comment.
Create an issue to link them (in your fork or PCL) so we don't forget
kunaltyagi
left a comment
kunaltyagi
left a comment
There was a problem hiding this comment.
LGTM
Tutorial and code are simple enough :)
|
again. Do not merge until executors are merged into the main repo |
kunaltyagi
added
needs: pr merge
3 participants
No description provided.