Skip to content

[CUDA/OpenMP] Fix build errors#5155

Merged
kunaltyagi merged 2 commits intoPointCloudLibrary:masterfrom
larshg:fixBuildErrors
Feb 11, 2022
Merged

[CUDA/OpenMP] Fix build errors#5155
kunaltyagi merged 2 commits intoPointCloudLibrary:masterfrom
larshg:fixBuildErrors

Conversation

@larshg
Copy link
Copy Markdown
Contributor

@larshg larshg commented Feb 4, 2022

fixes #5154

@larshg larshg added module: common module: cuda changelog: fix Meta-information for changelog generation labels Feb 4, 2022
@larshg larshg force-pushed the fixBuildErrors branch 2 times, most recently from 3da32a3 to 82488d9 Compare February 4, 2022 21:19
@mvieth mvieth requested a review from kunaltyagi February 11, 2022 08:31
Copy link
Copy Markdown
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one std::max threw me off😅

All looks good (and ofc, teaches us agian: don't sprinkle using namespace willy nilly)

@kunaltyagi kunaltyagi merged commit cea5b2f into PointCloudLibrary:master Feb 11, 2022
@larshg larshg deleted the fixBuildErrors branch February 11, 2022 18:17
ceccocats pushed a commit to lucabart97/pcl_custom_allocator that referenced this pull request Jan 14, 2023
* Fix namespace clashing between cub and thrust::cub.

* Fix VS2022 error C3052: 'k': variable doesn't appear in a data-sharing clause under a default(none) clause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: fix Meta-information for changelog generation module: common module: cuda

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[compile error] cannot build pcl 1.12.1 with cuda 11.6

3 participants