Fix net rental and CMS zero targets - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- treat SOI rent and royalty net income as signed when materializing amount targets\n- skip CMS Medicaid latest-month zero enrollment facts when the same target has positive observations, avoiding bad RI zero rows\n- add focused regression coverage for both target-surface fixes\n\n## Validation\n- uv run --python 3.13 ruff check tools/build_us_fiscal_refresh_release.py packages/populace-build/src/populace/build/us_runtime/fiscal_targets.py packages/populace-build/tests/test_us_fiscal_refresh_builder.py packages/populace-build/tests/test_us_fiscal_targets.py\n- uv run --python 3.13 --package populace-build --with pytest python -m pytest packages/populace-build/tests/test_us_fiscal_refresh_builder.py packages/populace-build/tests/test_us_fiscal_targets.py -q\n- compile check: corrected full CD target registry has 33,125 specs and no RI CMS enrollment rows\n\n## Notes\n- Corrected-surface candidate and incumbent read-only scores are running locally; I will add results when they complete.\n