Escalate completion budgets on length-truncation instead of scoring the death - #151
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150 — a completion-cap exhaustion is an environment error, not a serving fact (the onboarding gauntlet's principle, applied at run time). Gates the #139 v2 rerun.
finish_reason=lengthwith missing cells → retry with the budget doubled, capped at a per-model ceiling (128k default; model-card/provider maxima where lower, e.g. Gemini 3.6's documented 64k output limit).next_completion_budgetreturns None at the ceiling → remaining cells become ordinary misses with the distinct failure sourcebudget_exhausted_at_ceiling(vs format/parse sources), so the Explanation contract is unenforced — set the v2 scoring policy #145 parse-failure column can bucket them separately.Verification (independent of the implementing agent): full non-slow suite rerun locally — 569 passed, 5 skipped (+35 new tests); zero test deletions; ruff clean; core hunks reviewed (escalation loop, ceiling function, finish-reason normalization). Published v1 artifacts unaffected.
Authored by GPT-5.6 Sol via codex (ultra), reviewed and independently re-tested by Claude. Motivated by review feedback on the v2 contract.
🤖 Generated with Claude Code