This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Hover text visible#2552
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #2543 by ensuring that hover text is visible and updating hover color cues across the application. Key changes include:
- Adding an onClick handler to show a modal in the InfoCircleOutlined component.
- Changing hoverBackgroundColor from style.colors.WHITE to style.colors.BLUE_PRESSED in several HoverBox components for mobile layouts.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/household/output/NetIncomeBreakdown.jsx | Added an onClick event to trigger a modal on the info icon |
| src/layout/Header.jsx | Updated hoverBackgroundColor to use a blue pressed color for improved visual feedback |
Comments suppressed due to low confidence (3)
src/layout/Header.jsx:602
- Verify that the BLUE_PRESSED color provides sufficient contrast with overlaid text or icons to ensure accessibility standards are maintained.
hoverBackgroundColor={style.colors.BLUE_PRESSED}
src/layout/Header.jsx:670
- Ensure the blue pressed hover background in MobileDropdownHeader meets contrast requirements for clear readability.
hoverBackgroundColor={style.colors.BLUE_PRESSED}
src/layout/Header.jsx:733
- Confirm that the hover background color change in MobileDropdownItem maintains adequate contrast for users with visual impairments.
hoverBackgroundColor={style.colors.BLUE_PRESSED}
| @@ -320,13 +320,14 @@ function VariableArithmetic(props) { | |||
| className="info-icon-wrapper" | |||
| > | |||
| <InfoCircleOutlined | |||
There was a problem hiding this comment.
Consider adding an accessible label (such as an aria-label or title attribute) to the InfoCircleOutlined component so that screen readers can clearly communicate its purpose.
Suggested change
| <InfoCircleOutlined | |
| <InfoCircleOutlined | |
| aria-label="More information" |
SEEDART007
force-pushed
the
hover-correction
branch
from
May 20, 2025 07:40
ec516a5 to
afa5c63
Compare
anth-volk
self-requested a review
June 5, 2025 23:13
anth-volk
approved these changes
Jun 5, 2025
anth-volk
left a comment
anth-volk
left a comment
Collaborator
There was a problem hiding this comment.
This is definitely a visual improvement. Approved pending test passage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2543
Screen.Recording.2025-05-20.122614.mp4