Pin the microsim guard's blind spots; reject prefixed identifiers - #79
Merged
Conversation
Follow-up to #77, closing the three residuals from sol's round-3 MERGE verdict: - The qualified-constructor pattern gains a leading (?<!\w) so prefixed identifiers (notpolicyengine_us.Microsimulation) cannot false-positive. - MICROSIM_KNOWN_MISSES pins the guard's documented blind spots as five corpus entries (backslash continuation before import, hybrid backslash-then-paren import, aliased constructor, import *, dot-split qualified constructor) with a test asserting they are NOT caught — a future tightening moves entries to MICROSIM_BANNED_SAMPLES. The module docstring now states exactly what is caught vs missed. - The plugin-maintenance skill's documented scan-suffix list adds .ipynb, matching SCAN_SUFFIXES. uv run pytest --ignore=tests/test_skill_examples.py: 97 passed. Wrapper smoke build: OK. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77, closing the three residual nits from the round-3 adversarial review (sol, gpt-5.6-sol) that accompanied its MERGE verdict:
notpolicyengine_us.Microsimulationwould have tripped it. Now(?<!\w)policyengine_(us|uk)\b…, with an allowed-corpus entry pinning the fix.MICROSIM_KNOWN_MISSESpins the guard's five documented evasions (backslash continuation beforeimport, hybrid backslash-then-paren import, aliased constructor,import *, dot-split qualified constructor) with a test asserting they are not caught — so the limits are explicit, and any future tightening must consciously move an entry intoMICROSIM_BANNED_SAMPLES. The module docstring now states exactly what is caught vs missed..ipynb, matchingSCAN_SUFFIXES.Corpus: 12 banned + 11 allowed + 5 known-misses.
uv run pytest --ignore=tests/test_skill_examples.py: 97 passed. Wrapper smoke build: OK.🤖 Generated with Claude Code