Remove mixed computation metadata from variables#1677
Merged
Conversation
49e9c2a to
b2c399d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upratingmetadata from variables already computed byaddsadds/subtractsVerification
adds/subtracts, anduprating:conflicts=0uv run --no-sync ruff checkon touched variable filesuv run --no-sync ruff format --checkon touched variable filesuv run --no-sync python -c "from policyengine_uk import CountryTaxBenefitSystem; CountryTaxBenefitSystem(); print('uk import OK')"PYTHONPATH=/Users/maxghenis/policyengine-core uv run --no-sync python -c "from policyengine_uk import CountryTaxBenefitSystem; CountryTaxBenefitSystem(); print('uk import OK with local core')"uv run --with towncrier towncrier build --draft --version 2.88.18Companion cleanup for US: PolicyEngine/policyengine-us#8330. Core guard PR to follow after UK and US releases are live.