Remove mixed computation metadata from variables#8330
Merged
Conversation
9194c8b to
0e85944
Compare
0e85944 to
198980f
Compare
198980f to
f4a38b0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8330 +/- ##
===========================================
- Coverage 100.00% 94.57% -5.43%
===========================================
Files 3 14 +11
Lines 63 166 +103
Branches 0 2 +2
===========================================
+ Hits 63 157 +94
- Misses 0 9 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upratingmetadata from variables already computed by formulas oraddsaddspointers from state variables whose formulas already add the parameter-defined variable lists explicitlyVerification
test_variables_use_at_most_one_computation_modefailed with 21 conflicts before the default-uprating fixadds/subtracts, anduprating:conflicts=0CountryTaxBenefitSystem()under current core:conflicts=0CountryTaxBenefitSystem()with local PolicyEngine Core PR Add legislative reference for SNAP's 30% expected food contribution #495 onPYTHONPATH:conflicts=0missing_overrides=0uv run --no-sync pytest policyengine_us/tests/test_system_import.py policyengine_us/tests/microsimulation/data/test_extend_single_year_dataset.py -qPYTHONPATH=/Users/maxghenis/policyengine-core uv run --no-sync pytest policyengine_us/tests/test_system_import.py -quv run --no-sync ruff checkon touched variable, default-uprating, economic-assumptions, and test filesuv run --no-sync ruff format --checkon touched variable, default-uprating, economic-assumptions, and test filesuv run --with towncrier towncrier build --draft --version 1.691.14Companion cleanup for UK: PolicyEngine/policyengine-uk#1677. Core guard PR: PolicyEngine/policyengine-core#495.