Skip to content

MD Poverty Line Credit - #1099

Closed
fedderw wants to merge 37 commits into
PolicyEngine:masterfrom
fedderw:md-plc
Closed

MD Poverty Line Credit#1099
fedderw wants to merge 37 commits into
PolicyEngine:masterfrom
fedderw:md-plc

Conversation

@fedderw

@fedderw fedderw commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

Does not include credit against county income tax

Comment thread openfisca_us/parameters/gov/states/md/tax/income/credits/poverty_line_credit.yaml Outdated
Comment thread openfisca_us/variables/gov/states/md/tax/income/credits/md_poverty_line_credit.py Outdated
Comment thread openfisca_us/variables/gov/states/md/tax/income/credits/md_poverty_line_credit.py Outdated
Comment thread openfisca_us/variables/gov/states/md/tax/income/credits/md_poverty_line_credit.py Outdated
Comment thread openfisca_us/variables/gov/states/md/tax/income/credits/md_poverty_line_credit.py Outdated
Comment thread openfisca_us/variables/gov/states/md/tax/income/credits/md_poverty_line_credit.py Outdated
@nikhilwoodruff

Copy link
Copy Markdown
Collaborator

Thanks, left a few comments

@fedderw
fedderw marked this pull request as ready for review July 15, 2022 18:13
@codecov

codecov Bot commented Jul 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1099 (bd44cfe) into master (c1de029) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head bd44cfe differs from pull request most recent head 599e768. Consider uploading reports for the commit 599e768 to get more accurate results

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
+ Coverage   95.47%   95.49%   +0.01%     
==========================================
  Files         704      701       -3     
  Lines       12583    12568      -15     
  Branches      908      908              
==========================================
- Hits        12014    12002      -12     
+ Misses        533      532       -1     
+ Partials       36       34       -2     
Impacted Files Coverage Δ
...es/md/tax/income/credits/md_poverty_line_credit.py 100.00% <100.00%> (ø)
.../gov/irs/tax/federal_income/capital_gains/dwks9.py 100.00% <0.00%> (ø)
...gov/irs/tax/federal_income/capital_gains/dwks10.py 100.00% <0.00%> (ø)
.../ma/tax/income/credits/ma_dependent_care_credit.py 100.00% <0.00%> (ø)
...ncome/person/dividends/ordinary_dividend_income.py 100.00% <0.00%> (ø)
...ral_income/income_tax_before_refundable_credits.py 100.00% <0.00%> (ø)
...s/gov/irs/credits/refundable_payroll_tax_credit.py
...les/gov/states/md/tax/income/credits/ctc/md_ctc.py
...s/gov/irs/credits/income_tax_refundable_credits.py
...redits/income_tax_capped_non_refundable_credits.py
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1de029...599e768. Read the comment docs.

Comment thread openfisca_us/variables/gov/states/md/tax/income/credits/md_poverty_line_credit.py Outdated
@MaxGhenis

Copy link
Copy Markdown
Contributor

I added a notebook but getting this error, going to look into the standard deduction logic:

ValueError: Unable to set value "[[1550. 1550. 1550. ... 2350. 2350. 2350.]]" for variable "md_standard_deduction", as its length is 1 while there are 1001 tax_units in the simulation.

@MaxGhenis

Copy link
Copy Markdown
Contributor

As an intermediate hack I indexed the standard deduction to get it from two to one dimension. The graph reveals a problem with the current logic:
image

@fedderw

fedderw commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator Author

As an intermediate hack I indexed the standard deduction to get it from two to one dimension. The graph reveals a problem with the current logic: image

Is this a problem with the standard deduction or the plc?

@fedderw fedderw mentioned this pull request Jul 16, 2022
@fedderw
fedderw requested a review from MaxGhenis July 16, 2022 02:52
@fedderw fedderw added the states/md Maryland label Jul 18, 2022
income_tax_before_credits = tax_unit(
"md_income_tax_before_credits", period
)
md_non_refundable_eitc = tax_unit(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment linking to the form that this is non-refundable EITC, since the law is ambiguous

@MaxGhenis

Copy link
Copy Markdown
Contributor

Closing in favor of #1132, will file a new PR for EITC

@MaxGhenis MaxGhenis closed this Jul 18, 2022
@MaxGhenis MaxGhenis reopened this Jul 18, 2022
@MaxGhenis MaxGhenis closed this Jul 18, 2022
@fedderw
fedderw deleted the md-plc branch October 6, 2022 16:57
DTrim99 added a commit that referenced this pull request Jul 20, 2026
The Working Families Tax Credit's first tax year is 2022 (RCW
82.08.0206 as funded by ch. 195, Laws of 2021; DOR accepted the first
applications in February 2023 for TY2022). The amount and min_amount
parameters' first dated entries were 2022-01-01 with no preceding
zero, so the parameter system carried the 2022 values backward and
the credit paid the $300 childless minimum for 2021 and earlier
(found via a WA 2021 record in policyengine-taxsim #1099).

Add explicit 0000-01-01 zeros and a TY2021 regression test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

states/md Maryland

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants