fix: map bundled sources to their release package in changeset hygiene - #74
Open
marandaneto wants to merge 1 commit into
Open
fix: map bundled sources to their release package in changeset hygiene#74marandaneto wants to merge 1 commit into
marandaneto wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changeset hygiene asks for separate rrweb changesets in PostHog/posthog-js, even though those sources ship inside
posthog-js. Simply excluding rrweb would also stop checking that its changes have a browser SDK changeset.Example: PostHog/posthog-js#4808 (comment)
Changes
Add optional
releasePackagePathsconfiguration in.changeset/hygiene.json. A mapping such as"packages/rrweb/": "posthog-js"attributes changes under that directory to the package that ships them instead of the individual workspace packages.Directory boundaries are respected, trailing slashes are optional, and the most specific mapping wins. Invalid paths or unknown target packages produce a warning and retain normal workspace detection. Repositories without this configuration keep their existing behavior.
Add regression tests and a Node 22 CI job. No SDK release is needed.
Consumer configuration and script pin: PostHog/posthog-js#4810. Merge this PR before the consumer PR.
Validation
node --test .github/scripts/check-changeset-coverage.test.mjs.body=, which causes the workflow to delete the stale comment.git diff --checkpassed.1cce55f2e8766f0a4006ca39700fb0c2a903b832againstorigin/mainreported no actionable findings.Agent context
Human-driven (agent-assisted). Implemented with Pi using file tools, Git, GitHub CLI, Node tests, and autoreview. The mapping approach preserves the browser release requirement instead of hiding rrweb changes entirely. Human review is required.