Skip to content

fix: Fix github integration callback port conflict and permission deny handling#1167

Merged
charlesvien merged 1 commit intomainfrom
03-10-fix_dev_callback_port_conflict_and_permission_deny_handling
Mar 10, 2026
Merged

fix: Fix github integration callback port conflict and permission deny handling#1167
charlesvien merged 1 commit intomainfrom
03-10-fix_dev_callback_port_conflict_and_permission_deny_handling

Conversation

@charlesvien
Copy link
Member

@charlesvien charlesvien commented Mar 10, 2026 •
edited
Loading

Closes #1157
Closes #1161
Closes #1162

  1. Change github integration callback port from 8238 to 8239 to avoid conflict with MCP server
  2. Use isOtherOption() helper instead of raw string check for "other" option
  3. Cancel pending prompt when user denies a permission request

@charlesvien charlesvien changed the title Fix dev callback port conflict and permission deny handling fix: Fix dev callback port conflict and permission deny handling Mar 10, 2026
This was referenced Mar 10, 2026
Merged
Merged
@charlesvien Graphite App
Copy link
Member Author

charlesvien commented Mar 10, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@charlesvien charlesvien mentioned this pull request Mar 10, 2026
Merged
@charlesvien charlesvien changed the base branch from 03-09-sync_claude-agent-acp_upstream_v0.20.2_v0.21.0 to graphite-base/1167 March 10, 2026 16:57
@charlesvien charlesvien force-pushed the 03-10-fix_dev_callback_port_conflict_and_permission_deny_handling branch from 44b25cc to 9800a8a Compare March 10, 2026 16:57
This was referenced Mar 10, 2026
Merged
Merged
Merged
Closed
@charlesvien charlesvien force-pushed the 03-10-fix_dev_callback_port_conflict_and_permission_deny_handling branch from 9800a8a to b86066b Compare March 10, 2026 18:25
@charlesvien charlesvien changed the title fix: Fix dev callback port conflict and permission deny handling fix: Fix github integration callback port conflict and permission deny handling Mar 10, 2026
@charlesvien charlesvien marked this pull request as ready for review March 10, 2026 18:33
@charlesvien charlesvien force-pushed the 03-10-fix_dev_callback_port_conflict_and_permission_deny_handling branch from b86066b to 0ac3fb8 Compare March 10, 2026 18:33
@charlesvien charlesvien changed the base branch from graphite-base/1167 to 03-10-replace_plan_mode_keep_planning_with_feedback_option March 10, 2026 18:33
@charlesvien Graphite App
Copy link
Member Author

charlesvien commented Mar 10, 2026 •
edited
Loading

Merge activity

  • Mar 10, 8:28 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 10, 8:47 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 10, 8:55 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien changed the base branch from 03-10-replace_plan_mode_keep_planning_with_feedback_option to graphite-base/1167 March 10, 2026 20:37
@charlesvien charlesvien changed the base branch from graphite-base/1167 to main March 10, 2026 20:45
@charlesvien charlesvien force-pushed the 03-10-fix_dev_callback_port_conflict_and_permission_deny_handling branch from 0ac3fb8 to c131275 Compare March 10, 2026 20:46
@charlesvien charlesvien force-pushed the 03-10-fix_dev_callback_port_conflict_and_permission_deny_handling branch from c131275 to d489d9c Compare March 10, 2026 20:49
@charlesvien charlesvien mentioned this pull request Mar 10, 2026
Merged
@charlesvien charlesvien merged commit 2296698 into main Mar 10, 2026
15 checks passed
@charlesvien charlesvien deleted the 03-10-fix_dev_callback_port_conflict_and_permission_deny_handling branch March 10, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k11kirky k11kirky k11kirky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@charlesvien @k11kirky