Skip to content

fix: Add isDevBuild() util and namespace mock node dir per instance#1177

Merged
jonathanlab merged 2 commits intomainfrom
03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance
Mar 11, 2026
Merged

fix: Add isDevBuild() util and namespace mock node dir per instance#1177
jonathanlab merged 2 commits intomainfrom
03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance

Conversation

@charlesvien
Copy link
Member

@charlesvien charlesvien commented Mar 10, 2026

  1. Add isDevBuild() utility to env.ts to separate dev/prod feature gates from ASAR packaging checks
  2. Replace !app.isPackaged dev/prod checks across with isDevBuild()
  3. Namespace the mock node symlink dir per instance (/tmp/agent-node-dev vs /tmp/agent-node-prod) to avoid cross-contamination between simultaneous dev and prod builds
  4. Leave app.isPackaged in place for the 4 sites that genuinely need ASAR .unpacked path resolution

Copy link
Member Author

charlesvien commented Mar 10, 2026

@charlesvien charlesvien marked this pull request as ready for review March 10, 2026 20:50
@charlesvien charlesvien force-pushed the 03-10-prompt_history_shortcuts branch from a27f690 to 522811a Compare March 10, 2026 20:55
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from e94a9e3 to 61ed093 Compare March 10, 2026 20:55
@charlesvien charlesvien force-pushed the 03-10-prompt_history_shortcuts branch from 522811a to a517d7c Compare March 10, 2026 21:04
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from 61ed093 to f1569f4 Compare March 10, 2026 21:04
@charlesvien charlesvien changed the base branch from 03-10-prompt_history_shortcuts to graphite-base/1177 March 10, 2026 21:11
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from f1569f4 to 781ec83 Compare March 10, 2026 21:17
@graphite-app graphite-app bot changed the base branch from graphite-base/1177 to main March 10, 2026 21:17
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from 781ec83 to 8745865 Compare March 10, 2026 21:17
@charlesvien charlesvien changed the base branch from main to graphite-base/1177 March 10, 2026 22:01
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from 8745865 to 88bfca3 Compare March 10, 2026 22:01
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from 88bfca3 to 9366ced Compare March 10, 2026 22:10
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from 9366ced to ce0c5dc Compare March 11, 2026 06:01
@charlesvien charlesvien force-pushed the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch from ce0c5dc to fb88d60 Compare March 11, 2026 11:54
@graphite-app graphite-app bot changed the base branch from graphite-base/1177 to main March 11, 2026 11:54
@graphite-app
Copy link

graphite-app bot commented Mar 11, 2026

Merge activity

  • Mar 11, 11:54 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Mar 11, 12:21 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

@jonathanlab jonathanlab merged commit aa904af into main Mar 11, 2026
15 checks passed
@jonathanlab jonathanlab deleted the 03-10-add_isdevbuild_util_and_namespace_mock_node_dir_per_instance branch March 11, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants