Skip to content

fix/feat: Improve @ file tagging, reduce lag#241

Merged
charlesvien merged 8 commits into
mainfrom
charles/array-fix-at-tagging
Dec 10, 2025
Merged

fix/feat: Improve @ file tagging, reduce lag#241
charlesvien merged 8 commits into
mainfrom
charles/array-fix-at-tagging

Conversation

@charlesvien

@charlesvien charlesvien commented Dec 10, 2025

Copy link
Copy Markdown
Member
  • Improve @ file tagging in the message editor, reduce lag by switching to git ls-files over fs. It is very fast because it reads from the git index. It also respects .gitignore, which I think is something we would want anyways?

@charlesvien charlesvien marked this pull request as ready for review December 10, 2025 05:40
@charlesvien charlesvien requested a review from a team as a code owner December 10, 2025 05:40

@joshsny joshsny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a couple of comments :)

Comment thread apps/array/src/main/services/fs.ts Outdated
Comment thread apps/array/src/main/services/fs.ts Outdated
@charlesvien charlesvien force-pushed the charles/array-fix-at-tagging branch from 76c6f77 to 3711fbc Compare December 10, 2025 19:54
@charlesvien charlesvien force-pushed the charles/array-fix-at-tagging branch from 3711fbc to 455765c Compare December 10, 2025 20:00
@charlesvien charlesvien merged commit 0c1ee6b into main Dec 10, 2025
10 checks passed
@charlesvien charlesvien deleted the charles/array-fix-at-tagging branch December 10, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants