This repository was archived by the owner on Aug 6, 2026. It is now read-only.
feat: Refactor workspace service - #285
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 16, 2025
charlesvien
changed the title
charlesvien
marked this pull request as ready for review
December 16, 2025 23:47
charlesvien
changed the title
This was referenced Dec 17, 2025
Closed
joshsny
approved these changes
Dec 17, 2025
| useEffect(() => { | ||
| const unsubscribe = window.electronAPI?.workspace.onError((data) => { | ||
| toast.error("Workspace error", { description: data.message }); | ||
| const subscription = trpcVanilla.workspace.onError.subscribe(undefined, { |
Contributor
There was a problem hiding this comment.
nit: same thing as in the last pr in the stack, this handling of global event listeners feels awkward to reason with
Member
Author
Merge activity
|
charlesvien
force-pushed
the
feature/refactor-workspace-api
branch
from
December 17, 2025 17:42
4837dc0 to
c111b48
Compare
charlesvien
force-pushed
the
feature/refactor-repo-api
branch
from
December 17, 2025 17:42
13d6400 to
855fff6
Compare
charlesvien
changed the base branch from
feature/refactor-repo-api
to
graphite-base/285
December 17, 2025 17:46
charlesvien
force-pushed
the
feature/refactor-workspace-api
branch
from
December 17, 2025 17:50
c111b48 to
8dad721
Compare
This was referenced Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.