fix(ci): correct "damaged" guidance for PR installer builds#3278
Merged
Conversation
The PR installer is signed but not notarized. On current macOS, Gatekeeper rejects a quarantined, unnotarized download as "damaged and can't be opened", and the "right-click -> Open" bypass the sticky comment promised no longer applies. Update the sticky comment (and the two matching source comments) to tell testers this is expected and to clear the quarantine flag with `xattr -dr com.apple.quarantine`. Generated-By: PostHog Code Task-Id: 0798655f-ada5-466a-97f9-3e70676bca64
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Reviews (1): Last reviewed commit: "fix(ci): correct "damaged" guidance for ..." | Re-trigger Greptile |
gantoine
added
Stamphog
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
stamphog
Bot
removed
the
Stamphog
charlesvien
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We added a CI job that builds a macOS installer when the
build-installerlabel is added to a PR. But pulling down one of those images and opening it fails with "PostHog Code" is damaged and can't be opened. You should eject the disk image.The build is code-signed but deliberately not notarized (to stay fast). When the artifact is downloaded through a browser, macOS stamps it with the
com.apple.quarantineattribute, and on current macOS Gatekeeper rejects a quarantined, unnotarized app as "damaged" — the older "right-click → Open" bypass the sticky comment promised no longer works. So the file isn't corrupt; the guidance was just wrong.Changes
Keep the build unnotarized (fast) but fix the misleading docs in
pr-build-installer.yml:xattr -dr com.apple.quarantine "/Applications/PostHog Code.app".SKIP_NOTARIZE) to match.How did you test this?
echostrings within the existingrun: |block — no structural or indentation changes to the workflow.Automatic notifications
Created with PostHog Code