fix(bluebird): hide redundant task title under Thread heading in task view#3326
Merged
Merged
Conversation
… view
In the channels task view (`/website/$channelId/tasks/$taskId`), the docked
thread sidebar repeated the task title directly under its "Thread" heading. The
TaskDetail header right next to it already names the task, so the line was noise.
Add an optional `showTaskTitle` prop (default true) to `ThreadPanel`, forward it
through `ThreadSidebar`, and pass `showTaskTitle={false}` from the task route.
The channel home feed keeps the default, where the title still usefully
identifies which task's thread was opened.
Generated-By: PostHog Code
Task-Id: 9379e6fe-3846-468c-a040-107290049030
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
adboio
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Reviews (1): Last reviewed commit: "fix(bluebird): hide redundant task title..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Why: In the Project Bluebird channels task view, the docked thread sidebar repeated the task title directly beneath its "Thread" heading. When you're already inside a task, the
TaskDetailheader next to the sidebar already names it — so the echoed line was redundant noise.Changes
showTaskTitleprop (defaulttrue) toThreadPanel, forwarded throughThreadSidebar.showTaskTitle={false}, leaving a clean single-line "Thread" header.Scoped, presentational change — no new events or flags (the whole
/websitespace is already gated behindproject-bluebird).How did you test this?
pnpm turbo run typecheck --filter=@posthog/ui— passes.biome checkon the three changed files — clean.Automatic notifications
Created with PostHog Code