Skip to content

chore(cloud-tasks): keep cloud runtime controls visible#3415

Merged
tatoalo merged 1 commit into
mainfrom
posthog-code/keep-cloud-runtime-controls-visible
Jul 14, 2026
Merged

chore(cloud-tasks): keep cloud runtime controls visible#3415
tatoalo merged 1 commit into
mainfrom
posthog-code/keep-cloud-runtime-controls-visible

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Problem

Cloud tasks temporarily lose the selected model and reasoning controls after launch because the active session waits for preview configuration before rendering them

@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 92f4c90.

@tatoalo tatoalo self-assigned this Jul 14, 2026
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
@tatoalo tatoalo marked this pull request as ready for review July 14, 2026 10:27
@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix: preserve cloud reasoning preview st..." | Re-trigger Greptile

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-tested behavioral change to session config option seeding and merging logic, but it's T1d-complex with zero reviews and no ownership match — needs a team member to sign off before auto-approval.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
Comment thread packages/core/src/sessions/sessionService.ts Outdated
Comment thread packages/core/src/sessions/sessionService.ts
Generated-By: PostHog Code
Task-Id: 1cb995ca-b307-4d09-9c0c-b414323cbc42
@tatoalo tatoalo force-pushed the posthog-code/keep-cloud-runtime-controls-visible branch from da96d32 to 92f4c90 Compare July 14, 2026 10:40
@tatoalo tatoalo changed the title Keep cloud runtime controls visible after launch chore(cloud-tasks): keep cloud runtime controls visible Jul 14, 2026
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two P1 bot findings are both resolved and well-tested in the current diff, but this is a complex behavioral change to core session service logic (130 lines in sessionService.ts, cloud config option seeding and merge paths) with no human team reviewer sign-off on the current head. Request a human review before auto-approving.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
@tatoalo tatoalo requested a review from skoob13 July 14, 2026 10:54
@tatoalo tatoalo merged commit bc92492 into main Jul 14, 2026
31 checks passed
@tatoalo tatoalo deleted the posthog-code/keep-cloud-runtime-controls-visible branch July 14, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants