chore(deps): Move vite override to pnpm-workspace.yaml#3453
Merged
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Reviews (1): Last reviewed commit: "move vite override to pnpm-workspace.yam..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pnpm installwarns that thepnpmfield inpackage.jsonis no longer read by pnpm 10, so thevite: npm:rolldown-vite@7.3.1override from #3027 lives in a place pnpm ignores.Changes
Moved the override into the
overridessection ofpnpm-workspace.yaml(the pnpm 10 home for settings) and removed the deadpnpmfield. Rerunningpnpm installalso brought the lockfile in sync with the workspace overrides it had not been recording:node-abidedupes to the pinned 3.92.0 line,undiciundernode-gypmoves to 8.4.1 and the react, zod and @types pins are now recorded. Vite still resolves to rolldown-vite 7.3.1 everywhere.How did you test this?
pnpm installtwice (warning gone, lockfile stable on reinstall) andpnpm typecheck(23/23 tasks pass).Automatic notifications