Skip to content

chore(deps): Move vite override to pnpm-workspace.yaml#3453

Merged
charlesvien merged 2 commits into
mainfrom
chore/move-vite-override
Jul 15, 2026
Merged

chore(deps): Move vite override to pnpm-workspace.yaml#3453
charlesvien merged 2 commits into
mainfrom
chore/move-vite-override

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

pnpm install warns that the pnpm field in package.json is no longer read by pnpm 10, so the vite: npm:rolldown-vite@7.3.1 override from #3027 lives in a place pnpm ignores.

Changes

Moved the override into the overrides section of pnpm-workspace.yaml (the pnpm 10 home for settings) and removed the dead pnpm field. Rerunning pnpm install also brought the lockfile in sync with the workspace overrides it had not been recording: node-abi dedupes to the pinned 3.92.0 line, undici under node-gyp moves to 8.4.1 and the react, zod and @types pins are now recorded. Vite still resolves to rolldown-vite 7.3.1 everywhere.

How did you test this?

pnpm install twice (warning gone, lockfile stable on reinstall) and pnpm typecheck (23/23 tasks pass).

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "move vite override to pnpm-workspace.yam..." | Re-trigger Greptile

Comment thread pnpm-workspace.yaml
@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates denied this PR because it touches dependency/toolchain configuration (pnpm-workspace.yaml overrides, lockfile changes). This requires human review.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
@charlesvien
charlesvien requested a review from a team July 14, 2026 22:34
@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates denied this PR because it touches dependency/toolchain configuration — specifically pnpm overrides, the lockfile, and engine version constraints. These changes require human review.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
@charlesvien
charlesvien merged commit 01b8a59 into main Jul 15, 2026
36 checks passed
@charlesvien
charlesvien deleted the chore/move-vite-override branch July 15, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant