Skip to content

fix(message-editor): preserve comment anchors in pasted GitHub links #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Jul 24, 2026
Merged

fix(message-editor): preserve comment anchors in pasted GitHub links #3795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions apps/mobile/src/lib/githubIssueUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,28 @@ export interface ParsedGithubIssueUrl {
}

const GITHUB_ISSUE_URL_PATTERN =
/^https?:\/\/github\.com\/([^/\s]+)\/([^/\s]+)\/(issues|pull)\/(\d+)(?:[/?#].*)?$/;
/^https?:\/\/github\.com\/([^/\s]+)\/([^/\s]+)\/(issues|pull)\/(\d+)([/?#].*)?$/;

export function parseGithubIssueUrl(text: string): ParsedGithubIssueUrl | null {
const trimmed = text.trim();
const match = trimmed.match(GITHUB_ISSUE_URL_PATTERN);
if (!match) return null;

const [, owner, repo, segment, rawNumber] = match;
const [, owner, repo, segment, rawNumber, suffix = ""] = match;
const number = Number(rawNumber);
if (!Number.isInteger(number) || number <= 0) return null;

const kind: GithubRefKind = segment === "pull" ? "pr" : "issue";
// A fragment like #discussion_r123 anchors a specific comment, so keep the
// whole suffix — anchors such as #r123 only resolve on the /files subpage
// they were copied from. Without a fragment the tab/query suffix is noise.
const hashIndex = suffix.indexOf("#");
const hasFragment = hashIndex !== -1 && hashIndex < suffix.length - 1;
return {
kind,
owner,
repo,
number,
normalizedUrl: `https://github.com/${owner}/${repo}/${segment}/${number}`,
normalizedUrl: `https://github.com/${owner}/${repo}/${segment}/${number}${hasFragment ? suffix : ""}`,
};
}
39 changes: 38 additions & 1 deletion packages/core/src/message-editor/githubIssueUrl.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,45 @@ describe("parseGithubIssueUrl", () => {
},
},
{
name: "fragment is stripped from normalized URL",
name: "issue comment fragment is preserved",
input: "https://github.com/PostHog/code/issues/1808#issuecomment-123",
expected: {
kind: "issue",
owner: "PostHog",
repo: "code",
number: 1808,
normalizedUrl:
"https://github.com/PostHog/code/issues/1808#issuecomment-123",
},
},
{
name: "PR review comment fragment is preserved",
input:
"https://github.com/PostHog/posthog/pull/72409#discussion_r3647131256",
expected: {
kind: "pr",
owner: "PostHog",
repo: "posthog",
number: 72409,
normalizedUrl:
"https://github.com/PostHog/posthog/pull/72409#discussion_r3647131256",
},
},
{
name: "files tab suffix is kept when a comment fragment needs it",
input: "https://github.com/PostHog/code/pull/1454/files#r3647131256",
expected: {
kind: "pr",
owner: "PostHog",
repo: "code",
number: 1454,
normalizedUrl:
"https://github.com/PostHog/code/pull/1454/files#r3647131256",
},
},
{
name: "empty fragment is stripped from normalized URL",
input: "https://github.com/PostHog/code/issues/1808#",
expected: {
kind: "issue",
owner: "PostHog",
Expand Down
11 changes: 8 additions & 3 deletions packages/core/src/message-editor/githubIssueUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,28 @@ export interface ParsedGithubIssueUrl {
}

const GITHUB_ISSUE_URL_PATTERN =
/^https?:\/\/github\.com\/([^/\s]+)\/([^/\s]+)\/(issues|pull)\/(\d+)(?:[/?#].*)?$/;
/^https?:\/\/github\.com\/([^/\s]+)\/([^/\s]+)\/(issues|pull)\/(\d+)([/?#].*)?$/;

export function parseGithubIssueUrl(text: string): ParsedGithubIssueUrl | null {
const trimmed = text.trim();
const match = trimmed.match(GITHUB_ISSUE_URL_PATTERN);
if (!match) return null;

const [, owner, repo, segment, rawNumber] = match;
const [, owner, repo, segment, rawNumber, suffix = ""] = match;
const number = Number(rawNumber);
if (!Number.isInteger(number) || number <= 0) return null;

const kind: GithubRefKind = segment === "pull" ? "pr" : "issue";
// A fragment like #discussion_r123 anchors a specific comment, so keep the
// whole suffix — anchors such as #r123 only resolve on the /files subpage
// they were copied from. Without a fragment the tab/query suffix is noise.
const hashIndex = suffix.indexOf("#");
const hasFragment = hashIndex !== -1 && hashIndex < suffix.length - 1;
return {
kind,
owner,
repo,
number,
normalizedUrl: `https://github.com/${owner}/${repo}/${segment}/${number}`,
normalizedUrl: `https://github.com/${owner}/${repo}/${segment}/${number}${hasFragment ? suffix : ""}`,
};
}
Loading