fix(security): Keep OAuth token out of terminal environments#3799
fix(security): Keep OAuth token out of terminal environments#3799charlesvien wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "keep OAuth token out of terminal environ..." | Re-trigger Greptile |
be02137 to
a70ae4d
Compare
a70ae4d to
992320d
Compare
|
Note 🤖 stamphog reviewed Gates failed (auth deny-list, T2-never) and the change modifies OAuth token handling and shell credential-env scrubbing — genuinely security-sensitive. The diff looks correct and well-tested, but with no human/agent review beyond a bare reaction, there's no independent assurance to substitute for gate approval.
Gate mechanics and policy version
|

Problem
Resolves VERIA-351: OAuth access token leak in terminal shell environments.
Changes
Stop writing the OAuth token to the shared process env, and scrub the credential vars from the shell/pty env so repo scripts can't read them.
How did you test this?
Unit tests in
@posthog/workspace-server(shell env scrubbing, incl. viaadditionalEnv, and the auth adapter).Automatic notifications