fix(loops): Stop flaky ownership tab test#3817
Merged
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "wait for deselected loops tab panel to u..." | Re-trigger Greptile |
There was a problem hiding this comment.
Trivial test-only fix that replaces a timing-fragile assertion with a waitFor; diff matches the PR description exactly and carries no production risk.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 0L, 0F substantive, 7L/1F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T0 auto-approve: T0-deterministic (7L, 1F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ bf27356 · reviewed head 7708860 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LoopsListViewPresentation > shows only the selected ownership tabfails intermittently in CI withError: Tab does not control a panel, blocking unrelated PRs.Changes
Base UI's
Tabs.Paneldefaults tokeepMounted: falseand renders whilekeepMounted || mounted, so the deselected panel is inert and then unmounts when its transition ends. The test asserted the old panel was still present andinert, which only holds if the assertion lands inside that window. It now waits for the deselected loop to be gone, which is true whichever way the timing falls.How did you test this?
Ran the test five times locally; passes consistently. It previously passed locally and failed only on slower CI runners.
Automatic notifications