Skip to content

fix(loops): Stop flaky ownership tab test#3817

Merged
charlesvien merged 1 commit into
mainfrom
fix/loops-tab-panel-flaky-test
Jul 26, 2026
Merged

fix(loops): Stop flaky ownership tab test#3817
charlesvien merged 1 commit into
mainfrom
fix/loops-tab-panel-flaky-test

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

LoopsListViewPresentation > shows only the selected ownership tab fails intermittently in CI with Error: Tab does not control a panel, blocking unrelated PRs.

Changes

Base UI's Tabs.Panel defaults to keepMounted: false and renders while keepMounted || mounted, so the deselected panel is inert and then unmounts when its transition ends. The test asserted the old panel was still present and inert, which only holds if the assertion lands inside that window. It now waits for the deselected loop to be gone, which is true whichever way the timing falls.

How did you test this?

Ran the test five times locally; passes consistently. It previously passed locally and failed only on slower CI runners.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@trunk-io

trunk-io Bot commented Jul 26, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 26, 2026
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 7708860.

@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "wait for deselected loops tab panel to u..." | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial test-only fix that replaces a timing-fragile assertion with a waitFor; diff matches the PR description exactly and carries no production risk.

Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 0L, 0F substantive, 7L/1F incl. docs/generated/snapshots — within ceiling
tier T0 auto-approve: T0-deterministic (7L, 1F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ bf27356 · reviewed head 7708860

@charlesvien
charlesvien merged commit e60a53a into main Jul 26, 2026
34 checks passed
@charlesvien
charlesvien deleted the fix/loops-tab-panel-flaky-test branch July 26, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant