feat(canvas): first-class inlined asset imports in the build recipe (phase 4)#3827
Draft
k11kirky wants to merge 1 commit into
Draft
Conversation
Phase 4 (runtime expansion, code side) of the canvas application build pipeline plan: svg imports now compile to data URLs (usable directly as img/css sources) alongside json imports, with a shared contract fixture so the cloud adapter must inline them identically. Binary asset formats, workers, and WebAssembly need a binary source representation and land with the build-service schema evolution. Generated-By: PostHog Code Task-Id: 9e9a7b3c-f90d-4867-aa0d-b9acc83e26e1
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This was referenced Jul 26, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked PR chain (Graphite-style) — merge in this order:
posthog/posthog: #73725 (phase 1) → #73730 (phase 3) → #73731 (phase 4)PostHog/code: #3824 (phase 1) → #3825 (phase 2) → #3826 (phase 3) → #3827 (phase 4)Problem
Phase 4 ("Package and runtime expansion") of the canvas application build pipeline plan (#3823), the slice implementable ahead of production admission data: canvases couldn't import assets — an svg logo or a json config had no supported path through the build recipe.
Note
Stacked PR — merge order: #3824 (phase 1) → #3825 (phase 2) → #3826 (phase 3) → this PR (phase 4). Base branch is
posthog-code/canvas-build-pipeline-phase-3.Changes
img.src/ CSS values); json imports were already literals. Both inline into the bundle, so the artifact stays self-contained — no runtime asset fetches and nothing new for the sandbox CSP to allow.Deliberately not here: binary asset formats (png/woff2), web workers, and WebAssembly need a binary file representation in the source-project schema, and the plan's package-policy expansion is driven by observed admission failures — both belong to the build-service iteration once production data exists.
How did you test this?
sharedsuite 684 passed;turbo typecheckgreen for shared + workspace-server.Automatic notifications
Created with PostHog Code