Skip to content

feat(mobile): add Kimi K3 to the model picker (port #3869) - #3929

Merged
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/mobile-kimi-k3-model-picker
Jul 29, 2026
Merged

feat(mobile): add Kimi K3 to the model picker (port #3869)#3929
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/mobile-kimi-k3-model-picker

Conversation

@Gilbert09

Copy link
Copy Markdown
Member

Problem

The desktop app can drive the moonshotai/kimi-k3 model through the Claude adapter (behind a feature flag), but the React Native app's model picker didn't offer it. This ports that support to mobile so the two hosts match.

Ports desktop PRs #3869 (feat(models): add Kimi K3 to Claude adapter) and #3883 (fix(models): include Kimi in preview picker).

Why: keep the mobile model picker in parity with desktop for the flag-gated Kimi rollout.

Changes

  • Added a moonshotai/kimi-k3 ("Kimi K3") entry to the mobile model options with supportsReasoning: false — Kimi is absent from the shared Claude effort table, so no effort selector is shown and no stored effort is sent for it.
  • Gated the entry behind KIMI_MODEL_FLAG (imported from @posthog/shared, not hardcoded), following the existing useWarmTask flag pattern. Both composer screens read the flag and pass the filtered model list to the presentational composer.
  • When the flag is off, Kimi is hidden and a persisted per-task selection of moonshotai/kimi-k3 falls back to a visible model — mirroring desktop's stripKimiModelOption.
  • Reused the shared isModalModelId classifier for the gate rather than duplicating the id literal.
  • The selected id flows through the existing cloud-task creation path unchanged — Kimi is a normal gateway model id with no special-casing.

How did you test this?

  • Added options.test.ts covering: Kimi present when the flag is on, absent when off, the persisted-model fallback when off, and that Kimi reports no reasoning support.
  • pnpm --filter @posthog/mobile test — 62 files / 539 tests pass.
  • pnpm --filter @posthog/mobile lint — clean.
  • tsc --noEmit — no type errors in the touched files.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@Gilbert09
Gilbert09 requested a review from a team July 29, 2026 10:46
@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 33e1ab5.

@Gilbert09
Gilbert09 force-pushed the posthog-code/mobile-kimi-k3-model-picker branch from dc3e408 to d38641f Compare July 29, 2026 13:20
Ports the desktop Kimi K3 model support (#3869, #3883) to the React Native
app. Adds `moonshotai/kimi-k3` to the cloud-task model picker, gated on the
shared `KIMI_MODEL_FLAG`, with no reasoning-effort support (matching desktop,
where Kimi is absent from the Claude effort table).

When the flag is off Kimi is hidden and a persisted per-task selection of it
falls back to a visible model, mirroring desktop's stripKimiModelOption.

Generated-By: PostHog Code
Task-Id: 21ef821f-1517-4bd0-a79d-074848e1c2b0
@Gilbert09
Gilbert09 force-pushed the posthog-code/mobile-kimi-k3-model-picker branch from d38641f to 33e1ab5 Compare July 29, 2026 13:37
@talyn-app

talyn-app Bot commented Jul 29, 2026

Copy link
Copy Markdown

/trunk merge

@trunk-io
trunk-io Bot merged commit 5b47eda into main Jul 29, 2026
32 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/mobile-kimi-k3-model-picker branch July 29, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants