fix(loops): restore loops registry in Personal space - #4023
Conversation
Generated-By: PostHog Code Task-Id: 0b782cef-7a2c-4061-b4ac-3c2908a096ba
|
😎 Merged successfully - details. |
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
Prompt To Fix All With AI### Issue 1
packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsx:60-68
**Handle unresolved Personal channels**
On a fresh Personal-space route load, `useChannels` initially returns an empty channel list, so this falls through to `SpaceAttachedLoops` and briefly shows the scoped skeleton or raw-ID empty state while running its header side effects before switching to the registry.
### Issue 2
packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsx:68
**Preserve Personal-space navigation context**
Embedding `LoopsListView` here also runs its standalone-page header behavior, which clears the Spaces layout header and leaves the Personal loops view without its breadcrumb navigation context.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(loops): restore loops registry in pe..." | Re-trigger Greptile |
|
Note 🤖 stamphog reviewed Both unresolved Greptile findings check out against the diff: LoopsListView unconditionally clears the Spaces layout header (useSetHeaderContent(null)) so embedding it in the Personal-space route drops the breadcrumb navigation context, and useChannels starts with an empty channel list on load so the route briefly falls through to the scoped SpaceAttachedLoops empty state before switching — both are real, substantive UX regressions directly undercutting the PR's stated goal.
Gate mechanics and policy version
|
Generated-By: PostHog Code Task-Id: 0b782cef-7a2c-4061-b4ac-3c2908a096ba
Problem
The Spaces layout showed a context-scoped loop list in the Personal space. Unattached loops and resumable loop-builder tasks were therefore hidden behind a misleading empty state.
Why: People need to reliably find both the loop definitions they created and any active builder chats after leaving the creation task.
Changes
How did you test this?
Manually; got this list view
and the individual view
Automatic notifications
Created with PostHog Code